Remove SymbolTable::addBitcode as it is redundant.

[ruiu]

Summary

Remove SymbolTable::addBitcode as it is redundant.

[grimar]

LGTM.

ELF/InputFiles.cpp

static Symbol *createBitcodeSymbol(const std::vector<bool> &KeptComdats,
   if (ObjSym.isCommon())
     return Symtab->addCommon(
         CommonSymbol{&F, Name, Binding, Visibility, STT_OBJECT,
                      ObjSym.getCommonAlignment(), ObjSym.getCommonSize()});
 
   Defined New(&F, Name, Binding, Visibility, Type, 0, 0, nullptr);
   if (CanOmitFromDynSym)
     New.ExportDynamic = false;
-  return Symtab->addBitcode(New);
+  return Symtab->addDefined(New);
 }
 
 template <class ELFT>
 void BitcodeFile::parse(DenseSet<CachedHashStringRef> &ComdatGroups) {
   std::vector<bool> KeptComdats;
   for (StringRef S : Obj->getComdatTable())
     KeptComdats.push_back(ComdatGroups.insert(CachedHashStringRef(S)).second);
 

ELF/SymbolTable.h

public:
 
   ArrayRef<Symbol *> getSymbols() const { return SymVector; }
 
   Symbol *addUndefined(const Undefined &New);
   Symbol *addDefined(const Defined &New);
   Symbol *addShared(const SharedSymbol &New);
   Symbol *addLazyArchive(const LazyArchive &New);
   Symbol *addLazyObject(const LazyObject &New);
-  Symbol *addBitcode(const Defined &New);
   Symbol *addCommon(const CommonSymbol &New);
 
   Symbol *insert(const Symbol &New);
   void mergeProperties(Symbol *Old, const Symbol &New);
 
   void fetchLazy(Symbol *Sym);
 
   void scanVersionScript();

ELF/SymbolTable.cpp

if (Old->Visibility == STV_DEFAULT && (Old->isUndefined() || Old->isLazy())) {
     // in the same DSO.
     uint8_t Binding = Old->Binding;
     replaceSymbol(Old, &New);
     Old->Binding = Binding;
   }
   return Old;
 }
 
-Symbol *SymbolTable::addBitcode(const Defined &New) {
-  Symbol *Old = insert(New);
-  mergeProperties(Old, New);
-
-  if (Old->isPlaceholder()) {
-    replaceSymbol(Old, &New);
-    return Old;
-  }
-
-  int Cmp = compare(Old, &New);
-  if (Cmp > 0)
-    replaceSymbol(Old, &New);
-  else if (Cmp == 0)
-    reportDuplicate(Old, New.File, nullptr, 0);
-  return Old;
-}
-
 Symbol *SymbolTable::find(StringRef Name) {
   auto It = SymMap.find(CachedHashStringRef(Name));
   if (It == SymMap.end())
     return nullptr;
   if (It->second == -1)
     return nullptr;
   return SymVector[It->second];
 }