This is an archive of the discontinued LLVM Phabricator instance.

Differential D61815

[CFG] NFC: Modernize test/Analysis/initializers-cfg-output.cpp.
ClosedPublic

Authored by NoQ on May 10 2019, 8:04 PM.

Details

Reviewers
dcoughlin
xazax.hun
a_sidorin
rnkovacs
mikhail.ramalho
Szelethus
baloghadamsoftware
Charusso
Commits
rG1293de8b1733: [CFG] NFC: Modernize a test file for constructor initializer CFGs.
rL361587: [CFG] NFC: Modernize a test file for constructor initializer CFGs.
rC361587: [CFG] NFC: Modernize a test file for constructor initializer CFGs.
Summary

Move FileCheck directives around as we're used to, so that it was easy to understand what tests what and what effect do changes have.

Diff Detail

Repository
rC Clang

Event Timeline

NoQ created this revision.May 10 2019, 8:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2019, 8:04 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
NoQ added a child revision: D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass..May 10 2019, 8:14 PM
a_sidorin accepted this revision.May 11 2019, 10:59 AM

Wow, this is a cool idea!

This revision is now accepted and ready to land.May 11 2019, 10:59 AM
Szelethus accepted this revision.May 14 2019, 1:40 PM
Closed by commit rC361587: [CFG] NFC: Modernize a test file for constructor initializer CFGs. (authored by NoQ). · Explain WhyMay 23 2019, 6:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 201113

test/Analysis/initializers-cfg-output.cpp

// RUN: %clang_analyze_cc1 -std=c++11 -analyzer-checker=debug.DumpCFG -analyzer-config cfg-rich-constructors=false %s 2>&1 | FileCheck -check-prefixes=CHECK,WARNINGS %s // RUN: %clang_analyze_cc1 -std=c++11 -analyzer-checker=debug.DumpCFG -analyzer-config cfg-rich-constructors=false %s 2>&1 | FileCheck -check-prefixes=CHECK,WARNINGS %s
// RUN: %clang_analyze_cc1 -std=c++11 -analyzer-checker=debug.DumpCFG -analyzer-config cfg-rich-constructors=true %s 2>&1 | FileCheck -check-prefixes=CHECK,ANALYZER %s // RUN: %clang_analyze_cc1 -std=c++11 -analyzer-checker=debug.DumpCFG -analyzer-config cfg-rich-constructors=true %s 2>&1 | FileCheck -check-prefixes=CHECK,ANALYZER %s
// This file tests how we construct two different flavors of the Clang CFG - // This file tests how we construct two different flavors of the Clang CFG -
// the CFG used by the Sema analysis-based warnings and the CFG used by the // the CFG used by the Sema analysis-based warnings and the CFG used by the
// static analyzer. The difference in the behavior is checked via FileCheck // static analyzer. The difference in the behavior is checked via FileCheck
// prefixes (WARNINGS and ANALYZER respectively). When introducing new analyzer // prefixes (WARNINGS and ANALYZER respectively). When introducing new analyzer
// flags, no new run lines should be added - just these flags would go to the // flags, no new run lines should be added - just these flags would go to the
// respective line depending on where is it turned on and where is it turned // respective line depending on where is it turned on and where is it turned
// off. Feel free to add tests that test only one of the CFG flavors if you're // off. Feel free to add tests that test only one of the CFG flavors if you're
// not sure how the other flavor is supposed to work in your case. // not sure how the other flavor is supposed to work in your case.
class A { class A {
public: public:
// CHECK: A()
// CHECK: [B1 (ENTRY)]
// CHECK-NEXT: Succs (1): B0
// CHECK: [B0 (EXIT)]
// CHECK-NEXT: Preds (1): B1
A() {} A() {}
// CHECK: A(int i)
// CHECK: [B1 (ENTRY)]
// CHECK-NEXT: Succs (1): B0
// CHECK: [B0 (EXIT)]
// CHECK-NEXT: Preds (1): B1
A(int i) {} A(int i) {}
}; };
class B : public virtual A { class B : public virtual A {
public: public:
// CHECK: B()
// CHECK: [B2 (ENTRY)]
// CHECK-NEXT: Succs (1): B1
// CHECK: [B1]
// WARNINGS-NEXT: 1: (CXXConstructExpr, class A)
// ANALYZER-NEXT: 1: (CXXConstructExpr, A() (Base initializer), class A)
// CHECK-NEXT: 2: A([B1.1]) (Base initializer)
// CHECK-NEXT: Preds (1): B2
// CHECK-NEXT: Succs (1): B0
// CHECK: [B0 (EXIT)]
// CHECK-NEXT: Preds (1): B1
B() {} B() {}
// CHECK: B(int i)
// CHECK: [B2 (ENTRY)]
// CHECK-NEXT: Succs (1): B1
// CHECK: [B1]
// CHECK-NEXT: 1: i
// CHECK-NEXT: 2: [B1.1] (ImplicitCastExpr, LValueToRValue, int)
// WARNINGS-NEXT: 3: [B1.2] (CXXConstructExpr, class A)
// ANALYZER-NEXT: 3: [B1.2] (CXXConstructExpr, A([B1.2]) (Base initializer), class A)
// CHECK-NEXT: 4: A([B1.3]) (Base initializer)
// CHECK-NEXT: Preds (1): B2
// CHECK-NEXT: Succs (1): B0
// CHECK: [B0 (EXIT)]
// CHECK-NEXT: Preds (1): B1
B(int i) : A(i) {} B(int i) : A(i) {}
}; };
class C : public virtual A { class C : public virtual A {
public: public:
// CHECK: C()
// CHECK: [B2 (ENTRY)]
// CHECK-NEXT: Succs (1): B1
// CHECK: [B1]
// WARNINGS-NEXT: 1: (CXXConstructExpr, class A)
// ANALYZER-NEXT: 1: (CXXConstructExpr, A() (Base initializer), class A)
// CHECK-NEXT: 2: A([B1.1]) (Base initializer)
// CHECK-NEXT: Preds (1): B2
// CHECK-NEXT: Succs (1): B0
// CHECK: [B0 (EXIT)]
// CHECK-NEXT: Preds (1): B1
C() {} C() {}
// CHECK: C(int i)
// CHECK: [B2 (ENTRY)]
// CHECK-NEXT: Succs (1): B1
// CHECK: [B1]
// CHECK-NEXT: 1: i
// CHECK-NEXT: 2: [B1.1] (ImplicitCastExpr, LValueToRValue, int)
// WARNINGS-NEXT: 3: [B1.2] (CXXConstructExpr, class A)
// ANALYZER-NEXT: 3: [B1.2] (CXXConstructExpr, A([B1.2]) (Base initializer), class A)
// CHECK-NEXT: 4: A([B1.3]) (Base initializer)
// CHECK-NEXT: Preds (1): B2
// CHECK-NEXT: Succs (1): B0
// CHECK: [B0 (EXIT)]
// CHECK-NEXT: Preds (1): B1
C(int i) : A(i) {} C(int i) : A(i) {}
}; };
class TestOrder : public C, public B, public A { class TestOrder : public C, public B, public A {
int i; int i;
int& r; int& r;
public: public:
TestOrder(); TestOrder();
}; };
// CHECK: TestOrder::TestOrder()
// CHECK: [B2 (ENTRY)]
// CHECK-NEXT: Succs (1): B1
// CHECK: [B1]
// WARNINGS-NEXT: 1: (CXXConstructExpr, class A)
// ANALYZER-NEXT: 1: (CXXConstructExpr, A() (Base initializer), class A)
// CHECK-NEXT: 2: A([B1.1]) (Base initializer)
// WARNINGS-NEXT: 3: (CXXConstructExpr, class C)
// ANALYZER-NEXT: 3: (CXXConstructExpr, C() (Base initializer), class C)
// CHECK-NEXT: 4: C([B1.3]) (Base initializer)
// WARNINGS-NEXT: 5: (CXXConstructExpr, class B)
// ANALYZER-NEXT: 5: (CXXConstructExpr, B() (Base initializer), class B)
// CHECK-NEXT: 6: B([B1.5]) (Base initializer)
// WARNINGS-NEXT: 7: (CXXConstructExpr, class A)
// ANALYZER-NEXT: 7: (CXXConstructExpr, A() (Base initializer), class A)
// CHECK-NEXT: 8: A([B1.7]) (Base initializer)
// CHECK-NEXT: 9: /*implicit*/(int)0
// CHECK-NEXT: 10: i([B1.9]) (Member initializer)
// CHECK-NEXT: 11: this
// CHECK-NEXT: 12: [B1.11]->i
// CHECK-NEXT: 13: r([B1.12]) (Member initializer)
// WARNINGS-NEXT: 14: (CXXConstructExpr, class A)
// ANALYZER-NEXT: 14: (CXXConstructExpr, [B1.15], class A)
// CHECK-NEXT: 15: A a;
// CHECK-NEXT: Preds (1): B2
// CHECK-NEXT: Succs (1): B0
// CHECK: [B0 (EXIT)]
// CHECK-NEXT: Preds (1): B1
TestOrder::TestOrder() TestOrder::TestOrder()
: r(i), B(), i(), C() { : r(i), B(), i(), C() {
A a; A a;
} }
class TestControlFlow { class TestControlFlow {
int x, y, z; int x, y, z;
public: public:
TestControlFlow(bool b); TestControlFlow(bool b);
}; };
// CHECK: TestControlFlow::TestControlFlow(bool b)
// CHECK: [B5 (ENTRY)]
// CHECK-NEXT: Succs (1): B4
// CHECK: [B1]
// CHECK-NEXT: 1: [B4.4] ? [B2.1] : [B3.1]
// CHECK-NEXT: 2: y([B1.1]) (Member initializer)
// CHECK-NEXT: 3: this
// CHECK-NEXT: 4: [B1.3]->y
// CHECK-NEXT: 5: [B1.4] (ImplicitCastExpr, LValueToRValue, int)
// CHECK-NEXT: 6: z([B1.5]) (Member initializer)
// CHECK-NEXT: 7: int v;
// CHECK-NEXT: Preds (2): B2 B3
// CHECK-NEXT: Succs (1): B0
// CHECK: [B2]
// CHECK-NEXT: 1: 0
// CHECK-NEXT: Preds (1): B4
// CHECK-NEXT: Succs (1): B1
// CHECK: [B3]
// CHECK-NEXT: 1: 1
// CHECK-NEXT: Preds (1): B4
// CHECK-NEXT: Succs (1): B1
// CHECK: [B4]
// CHECK-NEXT: 1: 0
// CHECK-NEXT: 2: x([B4.1]) (Member initializer)
// CHECK-NEXT: 3: b
// CHECK-NEXT: 4: [B4.3] (ImplicitCastExpr, LValueToRValue, _Bool)
// CHECK-NEXT: T: [B4.4] ? ... : ...
// CHECK-NEXT: Preds (1): B5
// CHECK-NEXT: Succs (2): B2 B3
// CHECK: [B0 (EXIT)]
// CHECK-NEXT: Preds (1): B1
TestControlFlow::TestControlFlow(bool b) TestControlFlow::TestControlFlow(bool b)
: y(b ? 0 : 1) : y(b ? 0 : 1)
, x(0) , x(0)
, z(y) { , z(y) {
int v; int v;
} }
class TestDelegating { class TestDelegating {
int x, z; int x, z;
public: public:
TestDelegating() : TestDelegating(2, 3) {}
TestDelegating(int x, int z) : x(x), z(z) {}
};
// CHECK: TestDelegating()
// CHECK: [B2 (ENTRY)] // CHECK: [B2 (ENTRY)]
// CHECK: Succs (1): B1 // CHECK-NEXT: Succs (1): B1
// CHECK: [B1] // CHECK: [B1]
// WARNINGS: 1: (CXXConstructExpr, class A) // CHECK-NEXT: 1: 2
// ANALYZER: 1: (CXXConstructExpr, A() (Base initializer), class A) // CHECK-NEXT: 2: 3
// CHECK: 2: A([B1.1]) (Base initializer) // WARNINGS-NEXT: 3: [B1.1], [B1.2] (CXXConstructExpr, class TestDelegating)
// WARNINGS: 3: (CXXConstructExpr, class C) // ANALYZER-NEXT: 3: [B1.1], [B1.2] (CXXConstructExpr, TestDelegating([B1.1], [B1.2]) (Delegating initializer), class TestDelegating)
// ANALYZER: 3: (CXXConstructExpr, C() (Base initializer), class C) // CHECK-NEXT: 4: TestDelegating([B1.3]) (Delegating initializer)
// CHECK: 4: C([B1.3]) (Base initializer) // CHECK-NEXT: Preds (1): B2
// WARNINGS: 5: (CXXConstructExpr, class B) // CHECK-NEXT: Succs (1): B0
// ANALYZER: 5: (CXXConstructExpr, B() (Base initializer), class B)
// CHECK: 6: B([B1.5]) (Base initializer)
// WARNINGS: 7: (CXXConstructExpr, class A)
// ANALYZER: 7: (CXXConstructExpr, A() (Base initializer), class A)
// CHECK: 8: A([B1.7]) (Base initializer)
// CHECK: 9: /*implicit*/(int)0
// CHECK: 10: i([B1.9]) (Member initializer)
// CHECK: 11: this
// CHECK: 12: [B1.11]->i
// CHECK: 13: r([B1.12]) (Member initializer)
// WARNINGS: 14: (CXXConstructExpr, class A)
// ANALYZER: 14: (CXXConstructExpr, [B1.15], class A)
// CHECK: 15: A a;
// CHECK: Preds (1): B2
// CHECK: Succs (1): B0
// CHECK: [B0 (EXIT)] // CHECK: [B0 (EXIT)]
// CHECK: Preds (1): B1 // CHECK-NEXT: Preds (1): B1
// CHECK: [B5 (ENTRY)] TestDelegating() : TestDelegating(2, 3) {}
// CHECK: Succs (1): B4
// CHECK: TestDelegating(int x, int z)
// CHECK: [B2 (ENTRY)]
// CHECK-NEXT: Succs (1): B1
// CHECK: [B1] // CHECK: [B1]
// CHECK: 1: [B4.4] ? [B2.1] : [B3.1] // CHECK-NEXT: 1: x
// CHECK: 2: y([B1.1]) (Member initializer) // CHECK-NEXT: 2: [B1.1] (ImplicitCastExpr, LValueToRValue, int)
// CHECK: 3: this // CHECK-NEXT: 3: x([B1.2]) (Member initializer)
// CHECK: 4: [B1.3]->y // CHECK-NEXT: 4: z
// CHECK: 5: [B1.4] (ImplicitCastExpr, LValueToRValue, int) // CHECK-NEXT: 5: [B1.4] (ImplicitCastExpr, LValueToRValue, int)
// CHECK: 6: z([B1.5]) (Member initializer) // CHECK-NEXT: 6: z([B1.5]) (Member initializer)
// CHECK: 7: int v; // CHECK-NEXT: Preds (1): B2
// CHECK: Preds (2): B2 B3 // CHECK-NEXT: Succs (1): B0
// CHECK: Succs (1): B0
// CHECK: [B2]
// CHECK: 1: 0
// CHECK: Preds (1): B4
// CHECK: Succs (1): B1
// CHECK: [B3]
// CHECK: 1: 1
// CHECK: Preds (1): B4
// CHECK: Succs (1): B1
// CHECK: [B4]
// CHECK: 1: 0
// CHECK: 2: x([B4.1]) (Member initializer)
// CHECK: 3: b
// CHECK: 4: [B4.3] (ImplicitCastExpr, LValueToRValue, _Bool)
// CHECK: T: [B4.4] ? ... : ...
// CHECK: Preds (1): B5
// CHECK: Succs (2): B2 B3
// CHECK: [B0 (EXIT)]
// CHECK: Preds (1): B1
// CHECK: [B2 (ENTRY)]
// CHECK: Succs (1): B1
// CHECK: [B1]
// CHECK: 1: 2
// CHECK: 2: 3
// WARNINGS: 3: [B1.1], [B1.2] (CXXConstructExpr, class TestDelegating)
// ANALYZER: 3: [B1.1], [B1.2] (CXXConstructExpr, TestDelegating([B1.1], [B1.2]) (Delegating initializer), class TestDelegating)
// CHECK: 4: TestDelegating([B1.3]) (Delegating initializer)
// CHECK: Preds (1): B2
// CHECK: Succs (1): B0
// CHECK: [B0 (EXIT)] // CHECK: [B0 (EXIT)]
// CHECK: Preds (1): B1 // CHECK-NEXT: Preds (1): B1
TestDelegating(int x, int z) : x(x), z(z) {}
};