Page MenuHomePhabricator

Fixed creation of aliases in Windows build
ClosedPublic

Authored by AndreyChurbanov on May 8 2019, 4:02 AM.

Details

Summary

Current Windows build (install) creates a copy of libomp.lib interface library with wrong extension - .dll instead of .lib, thus we miss libiomp5md.lib file (created for backwards compatibility), and have two libiomp5md.dll files - one correct in /bin directory, another one broken in /lib directory.

The patch fixes this.

Diff Detail

Repository
rL LLVM

Event Timeline

AndreyChurbanov created this revision.May 8 2019, 4:02 AM
jlpeyton accepted this revision.May 8 2019, 8:22 AM

LGTM

This revision is now accepted and ready to land.May 8 2019, 8:22 AM
Closed by commit rL360595: Fixed creation of aliases in Windows build. (authored by achurbanov, committed by ). · Explain WhyMay 13 2019, 9:06 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2019, 9:06 AM

Hi. I'm seeing a cmake failure now, it looks like the last parenthesis was dropped. LIBDIR})"), LIBDIR})"

Sorry for committing the broken patch with missed ")" and "eol". Should now be fixed by r360602.