Page MenuHomePhabricator

[AMDGPU][test] Define local symbols used in amdgpu-relocs.s
ClosedPublic

Authored by MaskRay on May 6 2019, 6:38 AM.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

MaskRay created this revision.May 6 2019, 6:38 AM
Herald added a project: Restricted Project. · View Herald Transcript

This attempts to make the test more "genuine": compilers don't create local undefined symbols.

grimar added inline comments.May 6 2019, 6:53 AM
test/ELF/amdgpu-relocs.s
116–117

Do you need -DAG? I would expect strict order for these symbols I think.

MaskRay updated this revision to Diff 198271.May 6 2019, 6:57 AM
MaskRay marked an inline comment as done.

Delete -DAG

MaskRay marked an inline comment as done.May 6 2019, 6:58 AM
MaskRay added inline comments.
test/ELF/amdgpu-relocs.s
116–117

By default, "the output shall be sorted alphabetically by symbol name" (POSIX behavior). I just deleted -DAG

grimar accepted this revision.May 6 2019, 7:10 AM

This LGTM.

This revision is now accepted and ready to land.May 6 2019, 7:10 AM
This revision was automatically updated to reflect the committed changes.