This is an archive of the discontinued LLVM Phabricator instance.

Differential D61591

[MinGW] Use SEH by default on AArch64
ClosedPublic

Authored by mstorsjo on May 6 2019, 6:10 AM.

Details

Reviewers
rnk
efriedma
mgrang
ssijaric
Commits
rZORGd04539af2b7a: [MinGW] Use SEH by default on AArch64
rZORGc8eabf7b667c: [MinGW] Use SEH by default on AArch64
rGd04539af2b7a: [MinGW] Use SEH by default on AArch64
rGc8eabf7b667c: [MinGW] Use SEH by default on AArch64
rG5e100de2c7d3: [MinGW] Use SEH by default on AArch64
rC360081: [MinGW] Use SEH by default on AArch64
rL360081: [MinGW] Use SEH by default on AArch64
Summary

The implementation of SEH is pretty mature at this point.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.May 6 2019, 6:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2019, 6:10 AM
Herald added subscribers: kristof.beyls, javed.absar. · View Herald Transcript
rnk accepted this revision.May 6 2019, 10:53 AM

lgtm

This revision is now accepted and ready to land.May 6 2019, 10:53 AM
mgrang accepted this revision.May 6 2019, 12:03 PM
Closed by commit rL360081: [MinGW] Use SEH by default on AArch64 (authored by mstorsjo). · Explain WhyMay 6 2019, 2:16 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2019, 2:16 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
cfe/
trunk/
lib/
Driver/
ToolChains/
5 lines
test/
Driver/
4 lines

Diff 198339

cfe/trunk/lib/Driver/ToolChains/MinGW.cpp

Show First 20 Lines • Show All 430 Lines • ▼ Show 20 Lines
bool toolchains::MinGW::IsUnwindTablesDefault(const ArgList &Args) const { bool toolchains::MinGW::IsUnwindTablesDefault(const ArgList &Args) const {
Arg *ExceptionArg = Args.getLastArg(options::OPT_fsjlj_exceptions, Arg *ExceptionArg = Args.getLastArg(options::OPT_fsjlj_exceptions,
options::OPT_fseh_exceptions, options::OPT_fseh_exceptions,
options::OPT_fdwarf_exceptions); options::OPT_fdwarf_exceptions);
if (ExceptionArg && if (ExceptionArg &&
ExceptionArg->getOption().matches(options::OPT_fseh_exceptions)) ExceptionArg->getOption().matches(options::OPT_fseh_exceptions))
return true; return true;
return getArch() == llvm::Triple::x86_64; return getArch() == llvm::Triple::x86_64 ||
getArch() == llvm::Triple::aarch64;
} }
bool toolchains::MinGW::isPICDefault() const { bool toolchains::MinGW::isPICDefault() const {
return getArch() == llvm::Triple::x86_64; return getArch() == llvm::Triple::x86_64;
} }
bool toolchains::MinGW::isPIEDefault() const { return false; } bool toolchains::MinGW::isPIEDefault() const { return false; }
bool toolchains::MinGW::isPICDefaultForced() const { bool toolchains::MinGW::isPICDefaultForced() const {
return getArch() == llvm::Triple::x86_64; return getArch() == llvm::Triple::x86_64;
} }
llvm::ExceptionHandling llvm::ExceptionHandling
toolchains::MinGW::GetExceptionModel(const ArgList &Args) const { toolchains::MinGW::GetExceptionModel(const ArgList &Args) const {
if (getArch() == llvm::Triple::x86_64) if (getArch() == llvm::Triple::x86_64 || getArch() == llvm::Triple::aarch64)
return llvm::ExceptionHandling::WinEH; return llvm::ExceptionHandling::WinEH;
return llvm::ExceptionHandling::DwarfCFI; return llvm::ExceptionHandling::DwarfCFI;
} }
SanitizerMask toolchains::MinGW::getSupportedSanitizers() const { SanitizerMask toolchains::MinGW::getSupportedSanitizers() const {
SanitizerMask Res = ToolChain::getSupportedSanitizers(); SanitizerMask Res = ToolChain::getSupportedSanitizers();
Res |= SanitizerKind::Address; Res |= SanitizerKind::Address;
Res |= SanitizerKind::PointerCompare; Res |= SanitizerKind::PointerCompare;
▲ Show 20 Lines • Show All 113 Lines • Show Last 20 Lines

cfe/trunk/test/Driver/windows-exceptions.cpp

// RUN: %clang -target i686-windows-msvc -c %s -### 2>&1 | FileCheck -check-prefix=MSVC %s // RUN: %clang -target i686-windows-msvc -c %s -### 2>&1 | FileCheck -check-prefix=MSVC %s
// RUN: %clang -target x86_64-windows-msvc -c %s -### 2>&1 | FileCheck -check-prefix=MSVC %s // RUN: %clang -target x86_64-windows-msvc -c %s -### 2>&1 | FileCheck -check-prefix=MSVC %s
// RUN: %clang -target i686-windows-gnu -c %s -### 2>&1 | FileCheck -check-prefix=MINGW-DWARF %s // RUN: %clang -target i686-windows-gnu -c %s -### 2>&1 | FileCheck -check-prefix=MINGW-DWARF %s
// RUN: %clang -target x86_64-windows-gnu -c %s -### 2>&1 | FileCheck -check-prefix=MINGW-SEH %s // RUN: %clang -target x86_64-windows-gnu -c %s -### 2>&1 | FileCheck -check-prefix=MINGW-SEH %s
// RUN: %clang -target aarch64-windows-gnu -c %s -### 2>&1 | FileCheck -check-prefix=MINGW-DWARF %s // RUN: %clang -target aarch64-windows-gnu -fdwarf-exceptions -c %s -### 2>&1 | FileCheck -check-prefix=MINGW-DWARF %s
// RUN: %clang -target aarch64-windows-gnu -fseh-exceptions -c %s -### 2>&1 | FileCheck -check-prefix=MINGW-SEH %s // RUN: %clang -target aarch64-windows-gnu -c %s -### 2>&1 | FileCheck -check-prefix=MINGW-SEH %s
MSVC-NOT: -fdwarf-exceptions MSVC-NOT: -fdwarf-exceptions
MSVC-NOT: -fseh-exceptions MSVC-NOT: -fseh-exceptions
MINGW-DWARF: -fdwarf-exceptions MINGW-DWARF: -fdwarf-exceptions
MINGW-SEH: -munwind-tables MINGW-SEH: -munwind-tables
MINGW-SEH: -fseh-exceptions MINGW-SEH: -fseh-exceptions