[AMDGPU] gfx1010 verifier changes

[arsenm]

Should add verifier tests

[rampitec]

In D61521#1490093, @arsenm wrote:

Should add verifier tests

I do not see verifier tests anywhere for our BE in general. We need to add them all at once, i.e. a separate change.

[arsenm]

In D61521#1490105, @rampitec wrote:

In D61521#1490093, @arsenm wrote:

Should add verifier tests

I do not see verifier tests anywhere for our BE in general. We need to add them all at once, i.e. a separate change.

All at once would be worse than adding pieces as they are added

[kzhuravl]

LGTM with a todo about tests?

llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.cpp

if (Src0.isReg() && Src1.isReg() && Src2.isReg()) {
           !compareMachineOp(Src0, Src2)) {
         ErrInfo = "v_div_scale_{f32|f64} require src0 = src1 or src2";
         return false;
       }
     }
   }
 
   if (isSOPK(MI)) {
-    int64_t Imm = getNamedOperand(MI, AMDGPU::OpName::simm16)->getImm();
+    auto Op = getNamedOperand(MI, AMDGPU::OpName::simm16);
+    if (Desc.isBranch()) {
+      if (!Op->isMBB()) {
+        ErrInfo = "invalid branch target for SOPK instruction";
+        return false;
+      }
+    } else {
+      uint64_t Imm = Op->getImm();
       if (sopkIsZext(MI)) {
         if (!isUInt<16>(Imm)) {
           ErrInfo = "invalid immediate for SOPK instruction";
           return false;
         }
       } else {
         if (!isInt<16>(Imm)) {
           ErrInfo = "invalid immediate for SOPK instruction";
           return false;
         }
       }
     }
+  }
 
   if (Desc.getOpcode() == AMDGPU::V_MOVRELS_B32_e32 ||
       Desc.getOpcode() == AMDGPU::V_MOVRELS_B32_e64 ||
       Desc.getOpcode() == AMDGPU::V_MOVRELD_B32_e32 ||
       Desc.getOpcode() == AMDGPU::V_MOVRELD_B32_e64) {
     const bool IsDst = Desc.getOpcode() == AMDGPU::V_MOVRELD_B32_e32 ||
                        Desc.getOpcode() == AMDGPU::V_MOVRELD_B32_e64;