Page MenuHomePhabricator

[libcxx] cmake - guard list remove
AcceptedPublic

Authored by bcain on May 1 2019, 2:29 PM.

Details

Summary

REMOVE_ITEM fails if CMAKE_REQUIRED_LIBRARIES is empty.

Diff Detail

Event Timeline

bcain created this revision.May 1 2019, 2:29 PM
ldionne accepted this revision.May 1 2019, 3:03 PM

I have a workaround for this locally. I guess this is only relevant with older CMakes.

This revision is now accepted and ready to land.May 1 2019, 3:03 PM
bcain added a comment.May 1 2019, 4:23 PM

I have a workaround for this locally. I guess this is only relevant with older CMakes.

Oh yeah? "Version 3.4.3 " is specified as the minimum on the llvm project docs. Would that one avoid the problem?

I'll push this change but also work on getting our local build system upgraded.

I have a workaround for this locally. I guess this is only relevant with older CMakes.

Oh yeah? "Version 3.4.3 " is specified as the minimum on the llvm project docs. Would that one avoid the problem?

I don't know what version of CMake supports that, but I think 3.9.3 doesn't. In any case, the fix is trivial.