This is an archive of the discontinued LLVM Phabricator instance.

[crtbegin] Fix an off-by-1 bug in __do_fini
ClosedPublic

Authored by MaskRay on May 1 2019, 12:18 AM.

Reviewers

Commits

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 1 2019, 12:18 AM

LGTM, thanks!

This revision is now accepted and ready to land.May 2 2019, 11:53 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

crt/

2 lines

Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Lines	static void __attribute__((used)) __do_fini() {
if (__cxa_finalize)		if (__cxa_finalize)
__cxa_finalize(__dso_handle);		__cxa_finalize(__dso_handle);

#ifndef CRT_HAS_INITFINI_ARRAY		#ifndef CRT_HAS_INITFINI_ARRAY
if (__deregister_frame_info)		if (__deregister_frame_info)
__deregister_frame_info(__EH_FRAME_LIST__);		__deregister_frame_info(__EH_FRAME_LIST__);

const size_t n = __DTOR_LIST_END__ - __DTOR_LIST__ - 1;		const size_t n = __DTOR_LIST_END__ - __DTOR_LIST__ - 1;
for (size_t i = 1; i < n; i++) __DTOR_LIST__[i]();		for (size_t i = 1; i <= n; i++) __DTOR_LIST__[i]();
#endif		#endif
}		}

#ifdef CRT_HAS_INITFINI_ARRAY		#ifdef CRT_HAS_INITFINI_ARRAY
__attribute__((section(".fini_array"),		__attribute__((section(".fini_array"),
used)) static void (*__fini)(void) = __do_fini;		used)) static void (*__fini)(void) = __do_fini;
#else // CRT_HAS_INITFINI_ARRAY		#else // CRT_HAS_INITFINI_ARRAY
#if defined(__i386__) \|\| defined(__x86_64__)		#if defined(__i386__) \|\| defined(__x86_64__)
Show All 9 Lines