Page MenuHomePhabricator

[pstl] Move the dummy standard library headers to extra/
AbandonedPublic

Authored by ldionne on Apr 30 2019, 1:58 PM.

Details

Reviewers
MikeDvorskiy
Summary

Alternative to approach suggested in https://reviews.llvm.org/D60537#1473987.

Event Timeline

ldionne created this revision.Apr 30 2019, 1:58 PM
ldionne abandoned this revision.Jun 20 2019, 11:25 AM

Louis,
thanks for the alternative proposal.

A couple of question:

  1. What's motivation to change "stdlib" to "extra"? To avoid some confusing? (because "stdlib" is not a part of the standard library here)
  2. Can we keep "pstl" name (instead of proposed "include")? The fact is many people have already use PSTL code (as "third party" headers) and a usage model is following:

#include "pstl/execution"
#include "pstl/algorithm"
#include "pstl/numeric"
#include "pstl/memory"

We would not like to force them changing #include "pstl/execution" to #include "include/execution"

Louis,
thanks for the alternative proposal.

A couple of question:

  1. What's motivation to change "stdlib" to "extra"? To avoid some confusing? (because "stdlib" is not a part of the standard library here)
  2. Can we keep "pstl" name (instead of proposed "include")? The fact is many people have already use PSTL code (as "third party" headers) and a usage model is following:

    #include "pstl/execution" #include "pstl/algorithm" #include "pstl/numeric" #include "pstl/memory"

    We would not like to force them changing #include "pstl/execution" to #include "include/execution"

I don't mind. All I care is that this stuff stays out of the main include directory.

...

I don't mind. All I care is that this stuff stays out of the main include directory.

So, will you update the patch?

pstl/extra/include -> pstl/stdlib/pstl