This is an archive of the discontinued LLVM Phabricator instance.

[CommandLine] Add long option flag for cl::ParseCommandLineOptions . Part 5 of 5
ClosedPublic

Authored by hintonda on Apr 29 2019, 8:43 PM.

Event Timeline

hintonda created this revision.Apr 29 2019, 8:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2019, 8:43 PM
hintonda retitled this revision from [CommandLine] Add long option flag for cl::ParseCommandLineOptions to [CommandLine] Add long option flag for cl::ParseCommandLineOptions . Part 5 of 5.Apr 29 2019, 8:45 PM
MaskRay added inline comments.Apr 29 2019, 9:51 PM
llvm/test/tools/llvm-readobj/merged.test
13

Will you fix the message -section-headers?

hintonda updated this revision to Diff 197471.Apr 30 2019, 3:44 PM
hintonda marked an inline comment as done.

Rebase to minimize diff.

hintonda marked an inline comment as done.Apr 30 2019, 3:51 PM
hintonda added inline comments.
llvm/test/tools/llvm-readobj/merged.test
13

Fixed in D61270, which this patch includes.

hintonda updated this revision to Diff 198106.May 3 2019, 4:05 PM
  • Add LookupLongOption and simplify code.
MaskRay added inline comments.May 10 2019, 7:30 PM
llvm/lib/Support/CommandLine.cpp
91

Just move the definition here?

373

return nullptr;

hintonda marked an inline comment as done.May 10 2019, 8:26 PM
hintonda added inline comments.
llvm/lib/Support/CommandLine.cpp
91

Was trying to minimize the diff as much as possible, but there's no reason not to move these two here.

I could also move the others, but then it would be more difficult to see what I changed.

hintonda updated this revision to Diff 199122.May 10 2019, 8:30 PM
  • Address comments.
MaskRay accepted this revision.May 10 2019, 8:48 PM
This revision is now accepted and ready to land.May 10 2019, 8:48 PM
This revision was automatically updated to reflect the committed changes.