[X86] Run CFIInstrInserter on Windows if Dwarf is used
ClosedPublic
Actions

Authored by mstorsjo on Apr 29 2019, 1:26 AM.

Details

Reviewers

rnk
joerg
thegameg
violetav
djokov

Commits

rG0d754fd0166c: Merging r359496:
rL359952: Merging r359496:
rGc0d138d14788: [X86] Run CFIInstrInserter on Windows if Dwarf is used
rL359496: [X86] Run CFIInstrInserter on Windows if Dwarf is used

Summary

This is necessary since SVN r330706, as tail merging can include CFI instructions since then.

This fixes PR40322 and PR40012.

Diff Detail

Repository: rL LLVM

Event Timeline

mstorsjo created this revision.Apr 29 2019, 1:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2019, 1:26 AM

Herald added a subscriber: jfb. · View Herald Transcript

lgtm

This revision is now accepted and ready to land.Apr 29 2019, 1:08 PM

Closed by commit rL359496: [X86] Run CFIInstrInserter on Windows if Dwarf is used (authored by mstorsjo). · Explain WhyApr 29 2019, 1:28 PM

This revision was automatically updated to reflect the committed changes.

@tstellar Can we have this merged into 8.0.1?

Revision Contents
Changeset List

Path

Size

llvm/

trunk/

lib/

Target/

X86/

X86TargetMachine.cpp

6 lines

test/

CodeGen/

X86/

PR40322.ll

164 lines

Diff 197175

View Options

llvm/trunk/lib/Target/X86/X86TargetMachine.cpp