- User Since
- Dec 7 2017, 11:05 AM (19 w, 5 d)
Mon, Apr 23
Added comment in mergeSPUpdates(). Rebased patch.
Thu, Apr 19
Mar 20 2018
Addressed comments. Added support for merging instructions in X86FrameLowering::mergeSPUpdate() when CFI are present.
Feb 28 2018
Any other comments?
Feb 21 2018
Addressed comments from review.
Feb 2 2018
Jan 30 2018
Jan 29 2018
Does this solution look good?
Jan 15 2018
Removed copying CFI Instructions via copy constructor.
Dec 20 2017
Ok, then I would suggest that instead of this code we
- make CFI instructions duplicable;
- let TailDuplicator::shouldTailDuplicate return false for CFI and Darwin,
or better yet -
- fix generateCompactUnwindEncoding in ARM, AArch64 and x86 backends to fallback to DWARF when the info cannot fit into compact encoding.
Dec 19 2017
The idea behind this code is to fix Linux (which uses DWARF) and leave Darwin (which uses compact-unwind) as-is. That's why nonDuplicableInstruction returns true if (MBB->getParent()->getTarget().getTargetTriple().isOSDarwin()).