djokov (Djordje Kovacevic)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 7 2017, 11:05 AM (19 w, 5 d)

Recent Activity

Mon, Apr 23

djokov updated the diff for D42848: Correct dwarf unwind information in function epilogue.

Added comment in mergeSPUpdates(). Rebased patch.

Mon, Apr 23, 8:32 AM

Thu, Apr 19

djokov updated the diff for D42848: Correct dwarf unwind information in function epilogue.

Addressed comments.

Thu, Apr 19, 9:06 AM

Mar 20 2018

djokov updated the diff for D42848: Correct dwarf unwind information in function epilogue.

Addressed comments. Added support for merging instructions in X86FrameLowering::mergeSPUpdate() when CFI are present.

Mar 20 2018, 9:40 AM

Feb 28 2018

djokov added a comment to D42848: Correct dwarf unwind information in function epilogue.

Any other comments?

Feb 28 2018, 3:16 AM

Feb 21 2018

djokov updated the diff for D42848: Correct dwarf unwind information in function epilogue.

Addressed comments from review.

Feb 21 2018, 7:52 AM
djokov changed the edit policy for D42848: Correct dwarf unwind information in function epilogue.
Feb 21 2018, 7:35 AM
djokov changed the edit policy for D42848: Correct dwarf unwind information in function epilogue.
Feb 21 2018, 7:32 AM

Feb 2 2018

djokov created D42848: Correct dwarf unwind information in function epilogue.
Feb 2 2018, 8:26 AM

Jan 30 2018

djokov added a comment to D40979: [DWARF] Allow duplication of tails with CFI instructions.

If we end up duplicating a prologue like in the test case that r317726 broke, will the CFI be correct without Correct dwarf unwind information in function epilogue?

Jan 30 2018, 8:41 AM

Jan 29 2018

djokov added a comment to D40979: [DWARF] Allow duplication of tails with CFI instructions.

Does this solution look good?

Jan 29 2018, 6:44 AM

Jan 15 2018

djokov updated the diff for D40979: [DWARF] Allow duplication of tails with CFI instructions.

Removed copying CFI Instructions via copy constructor.

Jan 15 2018, 11:25 AM
djokov added inline comments to D40979: [DWARF] Allow duplication of tails with CFI instructions.
Jan 15 2018, 11:21 AM
djokov added a comment to D40979: [DWARF] Allow duplication of tails with CFI instructions.
Jan 15 2018, 9:30 AM
djokov updated the diff for D40979: [DWARF] Allow duplication of tails with CFI instructions.

I would advise to keep the NotDuplicable instruction attribute for now as long as our code cannot handle it. But moving the duplication logic into MachineInstr/MCCFIInstruction is a good idea anyway.

Jan 15 2018, 9:23 AM

Dec 20 2017

djokov added a comment to D40979: [DWARF] Allow duplication of tails with CFI instructions.

Ok, then I would suggest that instead of this code we

  1. make CFI instructions duplicable;
  2. let TailDuplicator::shouldTailDuplicate return false for CFI and Darwin,

or better yet -

  1. fix generateCompactUnwindEncoding in ARM, AArch64 and x86 backends to fallback to DWARF when the info cannot fit into compact encoding.
Dec 20 2017, 11:11 AM

Dec 19 2017

djokov added a comment to D40979: [DWARF] Allow duplication of tails with CFI instructions.

The idea behind this code is to fix Linux (which uses DWARF) and leave Darwin (which uses compact-unwind) as-is. That's why nonDuplicableInstruction returns true if (MBB->getParent()->getTarget().getTargetTriple().isOSDarwin()).

Dec 19 2017, 11:08 AM

Dec 7 2017

djokov created D40979: [DWARF] Allow duplication of tails with CFI instructions.
Dec 7 2017, 12:00 PM