This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [lit] Add register read tests for YMM registers (AVX)
ClosedPublic

Authored by mgorny on Apr 24 2019, 8:54 AM.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

mgorny created this revision.Apr 24 2019, 8:54 AM
mgorny updated this revision to Diff 196503.Apr 24 2019, 12:58 PM

Fixed unnecessary array in ymm_t decls.

This test is pretty much a reimplementation of TestYMMRegisters dotest test. I like this one more for several reasons, but if we're going to check this in, we should also delete the other one.

This test is pretty much a reimplementation of TestYMMRegisters dotest test. I like this one more for several reasons, but if we're going to check this in, we should also delete the other one.

Hmm, I see that the dotest test also includes support for 32-bit x86. Should I provide a 32-bit version of this one as well, or just neglect it?

mgorny updated this revision to Diff 196714.Apr 25 2019, 1:11 PM

Added a 32-bit version of the test, and constexpr.

I propose to keep the dotest tests until I reimplement ZMM as well, and then remove it altogether.

labath accepted this revision.Apr 26 2019, 12:57 AM

Added a 32-bit version of the test, and constexpr.

I propose to keep the dotest tests until I reimplement ZMM as well, and then remove it altogether.

Sounds like a plan. Thanks for doing this.

This revision is now accepted and ready to land.Apr 26 2019, 12:57 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2019, 6:20 AM
Herald added a subscriber: teemperor. · View Herald Transcript