[lldb] [lit] Add register read tests for YMM registers (AVX)

[mgorny]

Fixed unnecessary array in ymm_t decls.

[labath]

This test is pretty much a reimplementation of TestYMMRegisters dotest test. I like this one more for several reasons, but if we're going to check this in, we should also delete the other one.

[mgorny]

In D61074#1478859, @labath wrote:

This test is pretty much a reimplementation of TestYMMRegisters dotest test. I like this one more for several reasons, but if we're going to check this in, we should also delete the other one.

Hmm, I see that the dotest test also includes support for 32-bit x86. Should I provide a 32-bit version of this one as well, or just neglect it?

[mgorny]

Added a 32-bit version of the test, and constexpr.

I propose to keep the dotest tests until I reimplement ZMM as well, and then remove it altogether.

[labath]

In D61074#1479304, @mgorny wrote:

Added a 32-bit version of the test, and constexpr.

I propose to keep the dotest tests until I reimplement ZMM as well, and then remove it altogether.

Sounds like a plan. Thanks for doing this.

lldb/lit/Register/Inputs/x86-ymm-read.cpp

+#include <cstdint>
+
+struct alignas(32) ymm_t {
+  uint64_t a, b, c, d;
+};
+
+int main() {
+  ymm_t ymm0[2] = { 0x020406080A0C0E01, 0x030507090B0D0F00,
+                    0x838587898B8D8F80, 0x828486888A8C8E81 };
+  ymm_t ymm1[2] = { 0x121416181A1C1E11, 0x131517191B1D1F10,
+                    0x939597999B9D9F90, 0x929496989A9C9E91 };
+  ymm_t ymm2[2] = { 0x222426282A2C2E21, 0x232527292B2D2F20,
+                    0xA3A5A7A9ABADAFA0, 0xA2A4A6A8AAACAEA1 };
+  ymm_t ymm3[2] = { 0x323436383A3C3E31, 0x333537393B3D3F30,
+                    0xB3B5B7B9BBBDBFB0, 0xB2B4B6B8BABCBEB1 };
+  ymm_t ymm4[2] = { 0x424446484A4C4E41, 0x434547494B4D4F40,
+                    0xC3C5C7C9CBCDCFC0, 0xC2C4C6C8CACCCEC1 };
+  ymm_t ymm5[2] = { 0x525456585A5C5E51, 0x535557595B5D5F50,
+                    0xD3D5D7D9DBDDDFD0, 0xD2D4D6D8DADCDED1 };
+  ymm_t ymm6[2] = { 0x626466686A6C6E61, 0x636567696B6D6F60,
+                    0xE3E5E7E9EBEDEFE0, 0xE2E4E6E8EAECEEE1 };
+  ymm_t ymm7[2] = { 0x727476787A7C7E71, 0x737577797B7D7F70,
+                    0xF3F5F7F9FBFDFFF0, 0xF2F4F6F8FAFCFEF1 };
+  ymm_t ymm8[2] = { 0x838587898B8D8F80, 0x828486888A8C8E81,
+                    0x020406080A0C0E01, 0x030507090B0D0F00 };
+  ymm_t ymm9[2] = { 0x939597999B9D9F90, 0x929496989A9C9E91,
+                    0x121416181A1C1E11, 0x131517191B1D1F10 };
+  ymm_t ymm10[2] = { 0xA3A5A7A9ABADAFA0, 0xA2A4A6A8AAACAEA1,
+                     0x222426282A2C2E21, 0x232527292B2D2F20 };
+  ymm_t ymm11[2] = { 0xB3B5B7B9BBBDBFB0, 0xB2B4B6B8BABCBEB1,
+                     0x323436383A3C3E31, 0x333537393B3D3F30 };
+  ymm_t ymm12[2] = { 0xC3C5C7C9CBCDCFC0, 0xC2C4C6C8CACCCEC1,
+                     0x424446484A4C4E41, 0x434547494B4D4F40 };
+  ymm_t ymm13[2] = { 0xD3D5D7D9DBDDDFD0, 0xD2D4D6D8DADCDED1,
+                     0x525456585A5C5E51, 0x535557595B5D5F50 };
+  ymm_t ymm14[2] = { 0xE3E5E7E9EBEDEFE0, 0xE2E4E6E8EAECEEE1,
+                     0x626466686A6C6E61, 0x636567696B6D6F60 };
+  ymm_t ymm15[2] = { 0xF3F5F7F9FBFDFFF0, 0xF2F4F6F8FAFCFEF1,
+                     0x727476787A7C7E71, 0x737577797B7D7F70 };
+
+  asm volatile(
+    "vmovaps  %0, %%ymm0\n\t"
+    "vmovaps  %1, %%ymm1\n\t"
+    "vmovaps  %2, %%ymm2\n\t"
+    "vmovaps  %3, %%ymm3\n\t"
+    "vmovaps  %4, %%ymm4\n\t"
+    "vmovaps  %5, %%ymm5\n\t"
+    "vmovaps  %6, %%ymm6\n\t"
+    "vmovaps  %7, %%ymm7\n\t"
+    "vmovaps  %8, %%ymm8\n\t"
+    "vmovaps  %9, %%ymm9\n\t"
+    "vmovaps  %10, %%ymm10\n\t"
+    "vmovaps  %11, %%ymm11\n\t"
+    "vmovaps  %12, %%ymm12\n\t"
+    "vmovaps  %13, %%ymm13\n\t"
+    "vmovaps  %14, %%ymm14\n\t"
+    "vmovaps  %15, %%ymm15\n\t"
+    "\n\t"
+    "int3"
+    :
+    : "m"(ymm0), "m"(ymm1), "m"(ymm2), "m"(ymm3), "m"(ymm4), "m"(ymm5),
+      "m"(ymm6), "m"(ymm7), "m"(ymm8), "m"(ymm9), "m"(ymm10), "m"(ymm11),
+      "m"(ymm12), "m"(ymm13), "m"(ymm14), "m"(ymm15)
+    : "%ymm0", "%ymm1", "%ymm2", "%ymm3", "%ymm4", "%ymm5", "%ymm6", "%ymm7",
+      "%ymm8", "%ymm9", "%ymm10", "%ymm11", "%ymm12", "%ymm13", "%ymm14",
+      "%ymm15"
+  );
+
+  return 0;
+}

lldb/lit/Register/x86-ymm-read.test

+# XFAIL: system-darwin
+# XFAIL: system-windows
+# REQUIRES: native && target-x86_64 && native-cpu-avx
+# RUN: %clangxx %p/Inputs/x86-ymm-read.cpp -o %t
+# RUN: %lldb -b -s %s %t | FileCheck %s
+process launch
+
+register read --all
+# CHECK-DAG: xmm0 = {0x01 0x0e 0x0c 0x0a 0x08 0x06 0x04 0x02 0x00 0x0f 0x0d 0x0b 0x09 0x07 0x05 0x03}
+# CHECK-DAG: xmm1 = {0x11 0x1e 0x1c 0x1a 0x18 0x16 0x14 0x12 0x10 0x1f 0x1d 0x1b 0x19 0x17 0x15 0x13}
+# CHECK-DAG: xmm2 = {0x21 0x2e 0x2c 0x2a 0x28 0x26 0x24 0x22 0x20 0x2f 0x2d 0x2b 0x29 0x27 0x25 0x23}
+# CHECK-DAG: xmm3 = {0x31 0x3e 0x3c 0x3a 0x38 0x36 0x34 0x32 0x30 0x3f 0x3d 0x3b 0x39 0x37 0x35 0x33}
+# CHECK-DAG: xmm4 = {0x41 0x4e 0x4c 0x4a 0x48 0x46 0x44 0x42 0x40 0x4f 0x4d 0x4b 0x49 0x47 0x45 0x43}
+# CHECK-DAG: xmm5 = {0x51 0x5e 0x5c 0x5a 0x58 0x56 0x54 0x52 0x50 0x5f 0x5d 0x5b 0x59 0x57 0x55 0x53}
+# CHECK-DAG: xmm6 = {0x61 0x6e 0x6c 0x6a 0x68 0x66 0x64 0x62 0x60 0x6f 0x6d 0x6b 0x69 0x67 0x65 0x63}
+# CHECK-DAG: xmm7 = {0x71 0x7e 0x7c 0x7a 0x78 0x76 0x74 0x72 0x70 0x7f 0x7d 0x7b 0x79 0x77 0x75 0x73}
+# CHECK-DAG: xmm8 = {0x80 0x8f 0x8d 0x8b 0x89 0x87 0x85 0x83 0x81 0x8e 0x8c 0x8a 0x88 0x86 0x84 0x82}
+# CHECK-DAG: xmm9 = {0x90 0x9f 0x9d 0x9b 0x99 0x97 0x95 0x93 0x91 0x9e 0x9c 0x9a 0x98 0x96 0x94 0x92}
+# CHECK-DAG: xmm10 = {0xa0 0xaf 0xad 0xab 0xa9 0xa7 0xa5 0xa3 0xa1 0xae 0xac 0xaa 0xa8 0xa6 0xa4 0xa2}
+# CHECK-DAG: xmm11 = {0xb0 0xbf 0xbd 0xbb 0xb9 0xb7 0xb5 0xb3 0xb1 0xbe 0xbc 0xba 0xb8 0xb6 0xb4 0xb2}
+# CHECK-DAG: xmm12 = {0xc0 0xcf 0xcd 0xcb 0xc9 0xc7 0xc5 0xc3 0xc1 0xce 0xcc 0xca 0xc8 0xc6 0xc4 0xc2}
+# CHECK-DAG: xmm13 = {0xd0 0xdf 0xdd 0xdb 0xd9 0xd7 0xd5 0xd3 0xd1 0xde 0xdc 0xda 0xd8 0xd6 0xd4 0xd2}
+# CHECK-DAG: xmm14 = {0xe0 0xef 0xed 0xeb 0xe9 0xe7 0xe5 0xe3 0xe1 0xee 0xec 0xea 0xe8 0xe6 0xe4 0xe2}
+# CHECK-DAG: xmm15 = {0xf0 0xff 0xfd 0xfb 0xf9 0xf7 0xf5 0xf3 0xf1 0xfe 0xfc 0xfa 0xf8 0xf6 0xf4 0xf2}
+# CHECK-DAG: ymm0 = {0x01 0x0e 0x0c 0x0a 0x08 0x06 0x04 0x02 0x00 0x0f 0x0d 0x0b 0x09 0x07 0x05 0x03 0x80 0x8f 0x8d 0x8b 0x89 0x87 0x85 0x83 0x81 0x8e 0x8c 0x8a 0x88 0x86 0x84 0x82}
+# CHECK-DAG: ymm1 = {0x11 0x1e 0x1c 0x1a 0x18 0x16 0x14 0x12 0x10 0x1f 0x1d 0x1b 0x19 0x17 0x15 0x13 0x90 0x9f 0x9d 0x9b 0x99 0x97 0x95 0x93 0x91 0x9e 0x9c 0x9a 0x98 0x96 0x94 0x92}
+# CHECK-DAG: ymm2 = {0x21 0x2e 0x2c 0x2a 0x28 0x26 0x24 0x22 0x20 0x2f 0x2d 0x2b 0x29 0x27 0x25 0x23 0xa0 0xaf 0xad 0xab 0xa9 0xa7 0xa5 0xa3 0xa1 0xae 0xac 0xaa 0xa8 0xa6 0xa4 0xa2}
+# CHECK-DAG: ymm3 = {0x31 0x3e 0x3c 0x3a 0x38 0x36 0x34 0x32 0x30 0x3f 0x3d 0x3b 0x39 0x37 0x35 0x33 0xb0 0xbf 0xbd 0xbb 0xb9 0xb7 0xb5 0xb3 0xb1 0xbe 0xbc 0xba 0xb8 0xb6 0xb4 0xb2}
+# CHECK-DAG: ymm4 = {0x41 0x4e 0x4c 0x4a 0x48 0x46 0x44 0x42 0x40 0x4f 0x4d 0x4b 0x49 0x47 0x45 0x43 0xc0 0xcf 0xcd 0xcb 0xc9 0xc7 0xc5 0xc3 0xc1 0xce 0xcc 0xca 0xc8 0xc6 0xc4 0xc2}
+# CHECK-DAG: ymm5 = {0x51 0x5e 0x5c 0x5a 0x58 0x56 0x54 0x52 0x50 0x5f 0x5d 0x5b 0x59 0x57 0x55 0x53 0xd0 0xdf 0xdd 0xdb 0xd9 0xd7 0xd5 0xd3 0xd1 0xde 0xdc 0xda 0xd8 0xd6 0xd4 0xd2}
+# CHECK-DAG: ymm6 = {0x61 0x6e 0x6c 0x6a 0x68 0x66 0x64 0x62 0x60 0x6f 0x6d 0x6b 0x69 0x67 0x65 0x63 0xe0 0xef 0xed 0xeb 0xe9 0xe7 0xe5 0xe3 0xe1 0xee 0xec 0xea 0xe8 0xe6 0xe4 0xe2}
+# CHECK-DAG: ymm7 = {0x71 0x7e 0x7c 0x7a 0x78 0x76 0x74 0x72 0x70 0x7f 0x7d 0x7b 0x79 0x77 0x75 0x73 0xf0 0xff 0xfd 0xfb 0xf9 0xf7 0xf5 0xf3 0xf1 0xfe 0xfc 0xfa 0xf8 0xf6 0xf4 0xf2}
+# CHECK-DAG: ymm8 = {0x80 0x8f 0x8d 0x8b 0x89 0x87 0x85 0x83 0x81 0x8e 0x8c 0x8a 0x88 0x86 0x84 0x82 0x01 0x0e 0x0c 0x0a 0x08 0x06 0x04 0x02 0x00 0x0f 0x0d 0x0b 0x09 0x07 0x05 0x03}
+# CHECK-DAG: ymm9 = {0x90 0x9f 0x9d 0x9b 0x99 0x97 0x95 0x93 0x91 0x9e 0x9c 0x9a 0x98 0x96 0x94 0x92 0x11 0x1e 0x1c 0x1a 0x18 0x16 0x14 0x12 0x10 0x1f 0x1d 0x1b 0x19 0x17 0x15 0x13}
+# CHECK-DAG: ymm10 = {0xa0 0xaf 0xad 0xab 0xa9 0xa7 0xa5 0xa3 0xa1 0xae 0xac 0xaa 0xa8 0xa6 0xa4 0xa2 0x21 0x2e 0x2c 0x2a 0x28 0x26 0x24 0x22 0x20 0x2f 0x2d 0x2b 0x29 0x27 0x25 0x23}
+# CHECK-DAG: ymm11 = {0xb0 0xbf 0xbd 0xbb 0xb9 0xb7 0xb5 0xb3 0xb1 0xbe 0xbc 0xba 0xb8 0xb6 0xb4 0xb2 0x31 0x3e 0x3c 0x3a 0x38 0x36 0x34 0x32 0x30 0x3f 0x3d 0x3b 0x39 0x37 0x35 0x33}
+# CHECK-DAG: ymm12 = {0xc0 0xcf 0xcd 0xcb 0xc9 0xc7 0xc5 0xc3 0xc1 0xce 0xcc 0xca 0xc8 0xc6 0xc4 0xc2 0x41 0x4e 0x4c 0x4a 0x48 0x46 0x44 0x42 0x40 0x4f 0x4d 0x4b 0x49 0x47 0x45 0x43}
+# CHECK-DAG: ymm13 = {0xd0 0xdf 0xdd 0xdb 0xd9 0xd7 0xd5 0xd3 0xd1 0xde 0xdc 0xda 0xd8 0xd6 0xd4 0xd2 0x51 0x5e 0x5c 0x5a 0x58 0x56 0x54 0x52 0x50 0x5f 0x5d 0x5b 0x59 0x57 0x55 0x53}
+# CHECK-DAG: ymm14 = {0xe0 0xef 0xed 0xeb 0xe9 0xe7 0xe5 0xe3 0xe1 0xee 0xec 0xea 0xe8 0xe6 0xe4 0xe2 0x61 0x6e 0x6c 0x6a 0x68 0x66 0x64 0x62 0x60 0x6f 0x6d 0x6b 0x69 0x67 0x65 0x63}
+# CHECK-DAG: ymm15 = {0xf0 0xff 0xfd 0xfb 0xf9 0xf7 0xf5 0xf3 0xf1 0xfe 0xfc 0xfa 0xf8 0xf6 0xf4 0xf2 0x71 0x7e 0x7c 0x7a 0x78 0x76 0x74 0x72 0x70 0x7f 0x7d 0x7b 0x79 0x77 0x75 0x73}

lldb/utils/lit-cpuid/lit-cpuid.cpp

#if defined(__i386__) || defined(_M_IX86) || \
     defined(__x86_64__) || defined(_M_X64)
   StringMap<bool> features;
 
   if (!sys::getHostCPUFeatures(features))
     return 1;
 
   if (features["sse"])
     outs() << "sse\n";
+  if (features["avx"])
+    outs() << "avx\n";
 #endif
 
   return 0;
 }