This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] gfx1010 sgpr register changes
ClosedPublic

Authored by rampitec on Apr 23 2019, 4:41 PM.

Diff Detail

Event Timeline

rampitec created this revision.Apr 23 2019, 4:41 PM
This revision is now accepted and ready to land.Apr 24 2019, 10:11 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2019, 10:27 AM
arsenm added inline comments.Apr 24 2019, 10:38 AM
llvm/trunk/lib/Target/AMDGPU/AMDGPURegAsmNames.inc.cpp
327 ↗(On Diff #196485)

Needs tests for the new regs

llvm/trunk/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
4278 ↗(On Diff #196485)

Should be a hasX function

llvm/trunk/lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp
1044–1045 ↗(On Diff #196485)

This should be at least wrapped in a hasX function