This is an archive of the discontinued LLVM Phabricator instance.

[MemorySSA] Invalidate MemorySSA if AA or DT are invalidated.
ClosedPublic

Authored by asbirlea on Apr 23 2019, 3:20 PM.

Diff Detail

Event Timeline

asbirlea created this revision.Apr 23 2019, 3:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2019, 3:21 PM
Herald added subscribers: Prazek, jlebar. · View Herald Transcript
This revision is now accepted and ready to land.Apr 23 2019, 4:55 PM

Oh, you can add a test for this by using the new PM and an invalidate<aa> pass or invalidate<domtree>.

asbirlea updated this revision to Diff 196686.Apr 25 2019, 10:59 AM

Excellent suggestion! The invalidate needs to go into the Result internal to the analysis.
Updated and added test. PTAL.

This revision was automatically updated to reflect the committed changes.
RKSimon reopened this revision.Apr 30 2019, 5:35 AM
RKSimon added a subscriber: RKSimon.

@asbirlea I'm sorry but I had to revert this at rL359555 as it was causing windows buildbot failures: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/25459

This revision is now accepted and ready to land.Apr 30 2019, 5:35 AM
RKSimon requested changes to this revision.Apr 30 2019, 5:35 AM
This revision now requires changes to proceed.Apr 30 2019, 5:35 AM
asbirlea updated this revision to Diff 197428.Apr 30 2019, 1:35 PM

Updated test MemorySSA/invalidate.ll: What follows "InvalidateAnalysisPass" looks different on Windows.

asbirlea updated this revision to Diff 197464.Apr 30 2019, 3:31 PM

Rebase on ToT.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 30 2019, 3:41 PM
This revision was automatically updated to reflect the committed changes.