Page MenuHomePhabricator
Differential D61017

[AMDGPU][MC] Enabled constant expressions as operands of s_waitcnt
ClosedPublic
Actions

Authored by dp on Apr 23 2019, 6:58 AM.

Details

Reviewers
arsenm
artem.tamazov
Commits
rGb79af7930cac: [AMDGPU][MC] Enabled constant expressions as operands of s_waitcnt
rL361763: [AMDGPU][MC] Enabled constant expressions as operands of s_waitcnt
Summary

See bug 40820: https://bugs.llvm.org/show_bug.cgi?id=40820

This change also improves errors reporting (bug 41303).

Diff Detail

Repository
rL LLVM

Event Timeline

dp created this revision.Apr 23 2019, 6:58 AM
Herald added subscribers: t-tye, tpr, dstuttard and 5 others. · View Herald TranscriptApr 23 2019, 6:58 AM
artem.tamazov added a comment.May 24 2019, 4:54 AM

LGTM

test/MC/AMDGPU/sopp.s
148 ↗(On Diff #196239)

This would obfuscate even better ;)

s_waitcnt=1
s_waitcnt s_waitcnt
artem.tamazov accepted this revision.May 24 2019, 4:54 AM
This revision is now accepted and ready to land.May 24 2019, 4:54 AM
Closed by commit rL361763: [AMDGPU][MC] Enabled constant expressions as operands of s_waitcnt (authored by dpreobra). · Explain WhyMay 27 2019, 7:09 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2019, 7:09 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents
Changeset List

PathSize
llvm/
trunk/
lib/
Target/
AMDGPU/
AsmParser/
64 lines
test/
MC/
AMDGPU/
28 lines
24 lines

Diff 201531

View Options

llvm/trunk/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

Loading...
View Options

llvm/trunk/test/MC/AMDGPU/sopp-err.s

Loading...
View Options

llvm/trunk/test/MC/AMDGPU/sopp.s

Loading...