Page MenuHomePhabricator

[clang-format] Fix bug in reflow of block comments containing CR/LF

Authored by owenpan on Apr 23 2019, 12:17 AM.

Diff Detail

rC Clang

Event Timeline

owenpan created this revision.Apr 23 2019, 12:17 AM
MyDeveloperDay accepted this revision.Apr 23 2019, 1:25 AM

This looks logical to me, seems to fit with what `WhitespaceManager::appendNewlineText` is doing


This revision is now accepted and ready to land.Apr 23 2019, 1:25 AM
owenpan edited the summary of this revision. (Show Details)Apr 23 2019, 2:02 AM
owenpan updated this revision to Diff 196197.Apr 23 2019, 2:13 AM

Removes a no longer needed hack that worked around this bug when computing StartOfLine in the BreakableBlockComment::adjustWhitespace function.

Also updates the test case.

owenpan updated this revision to Diff 196261.Apr 23 2019, 9:36 AM

Removes a redundant test case.

This revision was automatically updated to reflect the committed changes.

Any chance we can still get this in LLVM 11?