Page MenuHomePhabricator

JVApen (JVApen)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 3 2015, 1:16 AM (246 w, 2 d)

Recent Activity

Dec 17 2017

JVApen added a comment to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

I'm missing some documentation to understand the corner cases. How does this check behave with suppressed warnings for checks which ain't currently checked. (Using -no-... on a code base or suppressing the warnings via the pragmas)

Dec 17 2017, 12:57 AM · Restricted Project

Dec 6 2017

JVApen added a comment to D40937: [clang-tidy] Infinite loop checker.

How does this check deal with atomic members?

Dec 6 2017, 11:19 PM · Restricted Project

Nov 23 2017

JVApen added a comment to D33537: [clang-tidy] Exception Escape Checker.

Looking at the documentation and the examples, it is unclear to me what the behavior of checking is when you call a function without throw/noexcept if you can't see the implementation. (Other cpp file)

Nov 23 2017, 11:05 PM · Restricted Project

Nov 9 2017

JVApen added a comment to D39799: [Tooling] Use FixedCompilationDatabase when `compile_flags.txt` is found..

How does this new file know if it should handle it's flags as it does in clang.exe or clang-cl.exe?

Nov 9 2017, 11:29 AM

Mar 20 2016

JVApen accepted D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer.

I'm not sure if I'm the right person to do reviews, as I'm mostly a user of the tool and have not yet done any developments or bug fixes to it.
However, from what I know from coding, this looks good to me.

Mar 20 2016, 3:53 AM

Nov 8 2015

JVApen added a comment to D14484: Formatting constructor initializer lists by putting them always on different lines.
Nov 8 2015, 3:50 AM · Restricted Project
JVApen retitled D14484: Formatting constructor initializer lists by putting them always on different lines from to Formatting constructor initializer lists by putting them always on different lines.
Nov 8 2015, 12:04 AM · Restricted Project

Jan 12 2015

JVApen updated the diff for D6833: Clang-format: Braces Indent Style Whitesmith.

I've fixed the method to do the indentation, by adapting indent in ContinuationIndenter::getNewLineColumn()

Jan 12 2015, 11:22 AM

Jan 5 2015

JVApen added a comment to D6833: Clang-format: Braces Indent Style Whitesmith.

I'm gonna assume you guys now the code base better then I do :p
By just indenting the braces, its gonna most likely be much cleaner code,
though then all code in UnwrappedLineParser will be the exact same for
Allman and Whitesmiths.
Any ideas how to make sure this will stay in sync in the future?

Jan 5 2015, 9:23 AM

Jan 3 2015

JVApen retitled D6833: Clang-format: Braces Indent Style Whitesmith from to Clang-format: Braces Indent Style Whitesmith.
Jan 3 2015, 1:27 AM