Paths

Table of Contentst

[TargetOption] Add option for enabling param entry val tracking dbg info
ClosedPublic
Actions

Authored by djtodoro on Apr 22 2019, 4:45 AM.

Details

Reviewers

aprantl
probinson

Commits

rGa5bbe8c8b93b: [TargetOption] Add option to ebanble the debug entry values
rL364395: [TargetOption] Add option to ebanble the debug entry values

Summary

The option enables debug info about parameter’s entry values.

Authors: @asowda, @NikolaPrica, @djtodoro, @ivanbaev

Diff Detail

Repository: rL LLVM

Event Timeline

djtodoro created this revision.Apr 22 2019, 4:45 AM

djtodoro added a parent revision: D58033: Add option for emitting dbg info for call site parameters.Apr 22 2019, 4:49 AM

djtodoro added a child revision: D58034: [IR/DIVar] Add flag for params that have unchanged values.

(A minor comment, which is not related to the code changes themselves, is that this should be a parent revision to D58033, and not vice-versa as it is now.)

djtodoro edited parent revisions, added: D60712: [DWARF] Add GNU extensions for call site info DWARF symbols; removed: D58033: Add option for emitting dbg info for call site parameters.May 6 2019, 1:26 AM

djtodoro added a child revision: D58033: Add option for emitting dbg info for call site parameters.

djtodoro removed a child revision: D58034: [IR/DIVar] Add flag for params that have unchanged values.May 6 2019, 1:28 AM

@dstenb Thanks for the comment! It is done. :)

aprantl accepted this revision.May 7 2019, 9:43 AM

This revision is now accepted and ready to land.May 7 2019, 9:43 AM

aprantl added inline comments.May 7 2019, 9:44 AM

include/llvm/CodeGen/CommandFlags.inc
308 ↗	(On Diff #196051)	I guess it would be more consistent to call this `EmitDebugEntryValues`

djtodoro marked 2 inline comments as done.May 13 2019, 1:29 AM

djtodoro added inline comments.

include/llvm/CodeGen/CommandFlags.inc
308 ↗	(On Diff #196051)	That makes sense. Thanks!

-Rename the option

-Rebase

Closed by commit rL364395: [TargetOption] Add option to ebanble the debug entry values (authored by djtodoro). · Explain WhyJun 26 2019, 1:36 AM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2019, 1:36 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

llvm/

trunk/

include/

llvm/

CodeGen/

CommandFlags.inc

6 lines

Target/

TargetOptions.h

6 lines

Diff 206612

View Options

llvm/trunk/include/llvm/CodeGen/CommandFlags.inc