Page MenuHomePhabricator

Use correct way to test for MIPS arch after rOMP355687
ClosedPublic

Authored by dim on Apr 20 2019, 1:00 PM.

Details

Summary

I ran into some issues after rOMP355687, where __atomic_fetch_add was
being used incorrectly on x86, and this turns out to be caused by the
following added conditionals:

#if defined(KMP_ARCH_MIPS)

The problem is, these macros are always defined, and are either 0 or 1
depending on the architecture. E.g. the correct way to test for MIPS
is:

#if KMP_ARCH_MIPS

Diff Detail

Repository
rOMP OpenMP

Event Timeline

dim created this revision.Apr 20 2019, 1:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2019, 1:00 PM
This revision is now accepted and ready to land.Apr 22 2019, 12:28 AM
petarj accepted this revision.Apr 22 2019, 7:52 AM
This revision was automatically updated to reflect the committed changes.