This is an archive of the discontinued LLVM Phabricator instance.

Differential D60917

Enable OpenMP build for 32-bit FreeBSD
ClosedPublic

Authored by dim on Apr 19 2019, 1:32 PM.

Details

Reviewers
emaste
jlpeyton
Hahnfeld
Commits
rG147ce2334c96: Enable OpenMP build for 32-bit FreeBSD
rL359716: Enable OpenMP build for 32-bit FreeBSD
rOMP359716: Enable OpenMP build for 32-bit FreeBSD
Summary

To be able to successfully build OpenMP on 32-bit FreeBSD, such as
FreeBSD/i386, I first had to provide a few wrappers (see D60916), and
then add KMP_OS_FREEBSD to the list of defines checked for 32-bit
architectures in kmp_runtime.cpp.

I have successfully built libomp.so and ran a bunch of test programs on
FreeBSD/i386 with this.

See also https://svnweb.freebsd.org/changeset/base/345283

Diff Detail

Event Timeline

dim created this revision.Apr 19 2019, 1:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2019, 1:32 PM
Herald added subscribers: openmp-commits, jdoerfert, guansong, krytarowski. · View Herald Transcript
Harbormaster completed remote builds in B30781: Diff 195903.Apr 19 2019, 1:34 PM
jlpeyton accepted this revision.Apr 30 2019, 12:22 PM

LGTM

This revision is now accepted and ready to land.Apr 30 2019, 12:22 PM
Closed by commit rOMP359716: Enable OpenMP build for 32-bit FreeBSD (authored by dim). · Explain WhyMay 1 2019, 12:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
runtime/
src/
2 lines

Diff 195903

runtime/src/kmp_runtime.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 8,233 Lines • ▼ Show 20 Lines#endif
} }
#else #else
#error "Unknown or unsupported OS" #error "Unknown or unsupported OS"
#endif // KMP_OS_LINUX || KMP_OS_DRAGONFLY || KMP_OS_FREEBSD || KMP_OS_NETBSD || #endif // KMP_OS_LINUX || KMP_OS_DRAGONFLY || KMP_OS_FREEBSD || KMP_OS_NETBSD ||
// KMP_OS_OPENBSD || KMP_OS_WINDOWS || KMP_OS_DARWIN || KMP_OS_HURD // KMP_OS_OPENBSD || KMP_OS_WINDOWS || KMP_OS_DARWIN || KMP_OS_HURD
#elif KMP_ARCH_X86 || KMP_ARCH_ARM || KMP_ARCH_AARCH || KMP_ARCH_MIPS #elif KMP_ARCH_X86 || KMP_ARCH_ARM || KMP_ARCH_AARCH || KMP_ARCH_MIPS
#if KMP_OS_LINUX || KMP_OS_WINDOWS || KMP_OS_HURD #if KMP_OS_LINUX || KMP_OS_FREEBSD || KMP_OS_WINDOWS || KMP_OS_HURD
// basic tuning // basic tuning
if (atomic_available) { if (atomic_available) {
if (num_vars <= 2) { // && ( team_size <= 8 ) due to false-sharing ??? if (num_vars <= 2) { // && ( team_size <= 8 ) due to false-sharing ???
retval = atomic_reduce_block; retval = atomic_reduce_block;
} }
} // otherwise: use critical section } // otherwise: use critical section
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines