This is an archive of the discontinued LLVM Phabricator instance.

Differential D60905

[OpenMP][LLVM] Add math functions support to OpenMP
AbandonedPublic

Authored by gtbercea on Apr 19 2019, 11:07 AM.

Details

Reviewers
ABataev
hfinkel
caomhin
tra
Summary

This patch adds rules for expanding math functions for sin and pow.

Diff Detail

Event Timeline

gtbercea created this revision.Apr 19 2019, 11:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2019, 11:07 AM
Herald added subscribers: llvm-commits, jdoerfert, guansong, jholewinski. · View Herald Transcript
ABataev added a reviewer: tra.Apr 19 2019, 11:09 AM
gtbercea added a child revision: D60907: [OpenMP] Add math functions support in OpenMP offloading.Apr 19 2019, 11:13 AM
jdoerfert added inline comments.Apr 19 2019, 1:33 PM
lib/Target/NVPTX/NVPTXISelLowering.cpp
595

The comment should go below the setOperationAction calls

gtbercea updated this revision to Diff 195917.Apr 19 2019, 2:29 PM
gtbercea edited the summary of this revision. (Show Details)
  • Fix comment.
Harbormaster completed remote builds in B30785: Diff 195917.Apr 19 2019, 2:29 PM
gtbercea marked an inline comment as done.Apr 19 2019, 2:29 PM
gtbercea updated this revision to Diff 195919.Apr 19 2019, 2:30 PM
  • Add sinl.
Harbormaster completed remote builds in B30787: Diff 195919.Apr 19 2019, 2:32 PM
gtbercea updated this revision to Diff 196441.Apr 24 2019, 6:55 AM
  • Add pow function to NVPTX function index.
Harbormaster completed remote builds in B30937: Diff 196441.Apr 24 2019, 6:58 AM
gtbercea retitled this revision from [OpenMP][LLVM][WIP] Add math functions support to OpenMP to [OpenMP][LLVM] Add math functions support to OpenMP.Apr 25 2019, 11:07 AM
jdoerfert added inline comments.Apr 29 2019, 6:50 PM
lib/Analysis/TargetLibraryInfo.cpp
558

I don't know what this is doing: Why do you have powX but not sinX?

gtbercea abandoned this revision.May 15 2019, 12:54 PM

Replaced by: D61399

Revision Contents

PathSize
lib/
Analysis/
6 lines
Target/
NVPTX/
8 lines

Diff 196441

lib/Analysis/TargetLibraryInfo.cpp

Show First 20 Lines • Show All 544 Lines • ▼ Show 20 Linesstatic void initialize(TargetLibraryInfoImpl &TLI, const Triple &T,
// but only used functions are provided to llvm. Moreover, most of the // but only used functions are provided to llvm. Moreover, most of the
// functions in libdevice don't map precisely to standard library functions. // functions in libdevice don't map precisely to standard library functions.
// //
// FIXME: Having no standard library prevents e.g. many fastmath // FIXME: Having no standard library prevents e.g. many fastmath
// optimizations, so this situation should be fixed. // optimizations, so this situation should be fixed.
if (T.isNVPTX()) { if (T.isNVPTX()) {
TLI.disableAllFunctions(); TLI.disableAllFunctions();
TLI.setAvailable(LibFunc_nvvm_reflect); TLI.setAvailable(LibFunc_nvvm_reflect);
TLI.setAvailable(LibFunc_pow);
TLI.setAvailable(LibFunc_pow_finite);
TLI.setAvailable(LibFunc_powf);
TLI.setAvailable(LibFunc_powf_finite);
TLI.setAvailable(LibFunc_powl);
TLI.setAvailable(LibFunc_powl_finite);
jdoerfertUnsubmitted
Not Done
ReplyInline Actions

I don't know what this is doing: Why do you have powX but not sinX?

jdoerfert: I don't know what this is doing: Why do you have `powX` but not `sinX`?
} else { } else {
TLI.setUnavailable(LibFunc_nvvm_reflect); TLI.setUnavailable(LibFunc_nvvm_reflect);
} }
TLI.addVectorizableFunctionsFromVecLib(ClVectorLibrary); TLI.addVectorizableFunctionsFromVecLib(ClVectorLibrary);
} }
TargetLibraryInfoImpl::TargetLibraryInfoImpl() { TargetLibraryInfoImpl::TargetLibraryInfoImpl() {
▲ Show 20 Lines • Show All 1,030 Lines • Show Last 20 Lines

lib/Target/NVPTX/NVPTXISelLowering.cpp

Show First 20 Lines • Show All 577 Lines • ▼ Show 20 LinesNVPTXTargetLowering::NVPTXTargetLowering(const NVPTXTargetMachine &TM,
setOperationAction(ISD::FMINNUM, MVT::f16, Promote); setOperationAction(ISD::FMINNUM, MVT::f16, Promote);
setOperationAction(ISD::FMAXNUM, MVT::f16, Promote); setOperationAction(ISD::FMAXNUM, MVT::f16, Promote);
setOperationAction(ISD::FMINIMUM, MVT::f16, Promote); setOperationAction(ISD::FMINIMUM, MVT::f16, Promote);
setOperationAction(ISD::FMAXIMUM, MVT::f16, Promote); setOperationAction(ISD::FMAXIMUM, MVT::f16, Promote);
// No FEXP2, FLOG2. The PTX ex2 and log2 functions are always approximate. // No FEXP2, FLOG2. The PTX ex2 and log2 functions are always approximate.
// No FPOW or FREM in PTX. // No FPOW or FREM in PTX.
setOperationAction(ISD::FPOW, MVT::f32, Expand);
setOperationAction(ISD::FPOW, MVT::f64, Expand);
setOperationAction(ISD::FPOW, MVT::f80, Expand);
setOperationAction(ISD::FSIN, MVT::f32, Expand);
setOperationAction(ISD::FSIN, MVT::f64, Expand);
setOperationAction(ISD::FSIN, MVT::f80, Expand);
// Now deduce the information based on the above mentioned // Now deduce the information based on the above mentioned
// actions // actions
jdoerfertUnsubmitted
Done
ReplyInline Actions

The comment should go below the setOperationAction calls

jdoerfert: The comment should go below the setOperationAction calls
computeRegisterProperties(STI.getRegisterInfo()); computeRegisterProperties(STI.getRegisterInfo());
} }
const char *NVPTXTargetLowering::getTargetNodeName(unsigned Opcode) const { const char *NVPTXTargetLowering::getTargetNodeName(unsigned Opcode) const {
switch ((NVPTXISD::NodeType)Opcode) { switch ((NVPTXISD::NodeType)Opcode) {
case NVPTXISD::FIRST_NUMBER: case NVPTXISD::FIRST_NUMBER:
break; break;
case NVPTXISD::CALL: case NVPTXISD::CALL:
▲ Show 20 Lines • Show All 4,308 Lines • Show Last 20 Lines