[CodeComplete] Remove obsolete isOutputBinary().

[sammccall]

Summary

It's never set to true. Its only effect would be to set stdout to binary mode.
Hopefully we have better ways of doing this by now :-)

[hokein]

I don't know the original motivation of this code. Since we never use it, so LGTM :)

[sammccall]

In D60871#1471738, @hokein wrote:

I don't know the original motivation of this code. Since we never use it, so LGTM :)

Looks like it was added in rL90209 and the only user was removed in rL116253.
It was a happy feature for a year, and then a sad one for 9 more...

source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

public:
   ///    The whole expression string that we are currently parsing. This
   ///    string needs to be equal to the input the user typed, and NOT the
   ///    final code that Clang is parsing.
   /// \param[out] position
   ///    The character position of the user cursor in the `expr` parameter.
   ///
   CodeComplete(CompletionRequest &request, clang::LangOptions ops,
                std::string expr, unsigned position)
-      : CodeCompleteConsumer(CodeCompleteOptions(), false),
+      : CodeCompleteConsumer(CodeCompleteOptions()),
         m_info(std::make_shared<GlobalCodeCompletionAllocator>()), m_expr(expr),
         m_position(position), m_request(request), m_desc_policy(ops) {
 
     // Ensure that the printing policy is producing a description that is as
     // short as possible.
     m_desc_policy.SuppressScope = true;
     m_desc_policy.SuppressTagKeyword = true;
     m_desc_policy.FullyQualifiedName = false;