This is an archive of the discontinued LLVM Phabricator instance.

[libc++][CMake] Always provide new/delete in libc++ unless specified otherwise
ClosedPublic

Authored by ldionne on Apr 16 2019, 3:06 PM.

Details

Summary

Let's not try to be clever and detect it based on the libc++abi setting.
The only build that puts new/delete in libc++abi is Apple's and we set
this CMake option explicitly in both libc++ and libc++abi. Complicated
dependent options hurt, let's avoid them when possible.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Apr 16 2019, 3:06 PM
phosek accepted this revision.Apr 16 2019, 4:16 PM

LGTM

This revision is now accepted and ready to land.Apr 16 2019, 4:16 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2019, 7:46 AM