Page MenuHomePhabricator

[TableGen] Include schedule model name in diagnostic.
ClosedPublic

Authored by simon_tatham on Apr 11 2019, 3:29 AM.

Details

Summary

If you have more than one schedule model in your TableGen target
definitions, then the diagnostic "No schedule information for
instruction 'foo'" is rather unhelpful, because it doesn't tell you
_which_ schedule model is missing the necessary information (or, as it
might be, missing the UnsupportedFeatures definition that would stop
it thinking it needed it).

Extended the message to include the name of the schedule model that
it's complaining about.

Diff Detail

Event Timeline

simon_tatham created this revision.Apr 11 2019, 3:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2019, 3:29 AM
javed.absar added inline comments.
llvm/test/TableGen/SchedModelError.td
8

Perhaps 's/model/SchedMachineModel/', but i am also happy with your changes as it is.

Adjusted message wording as suggested.

simon_tatham marked an inline comment as done.Apr 12 2019, 3:08 AM
javed.absar accepted this revision.Apr 12 2019, 5:39 AM
This revision is now accepted and ready to land.Apr 12 2019, 5:39 AM
This revision was automatically updated to reflect the committed changes.