Page MenuHomePhabricator
People javedabsar

javedabsar (Javed Absar)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2019, 1:28 AM (211 w, 6 d)

Recent Activity
View All

Jul 22 2022

javedabsar requested review of D130336: [mlir][NFC] Fix documentation.
Jul 22 2022, 2:23 AM · Restricted Project, Restricted Project

Jul 21 2022

javedabsar committed rG56094296f5de: Fix type in documentation (authored by javedabsar).
Fix type in documentation
Jul 21 2022, 10:43 AM · Restricted Project, Restricted Project
javedabsar closed D130274: Fix type in documentation.
Jul 21 2022, 10:42 AM · Restricted Project, Restricted Project
javedabsar requested review of D130274: Fix type in documentation.
Jul 21 2022, 7:48 AM · Restricted Project, Restricted Project

Jun 30 2022

javedabsar committed rGc2ecf1622479: [mlir][Inliner] Support recursion in Inliner (authored by javedabsar).
[mlir][Inliner] Support recursion in Inliner
Jun 30 2022, 10:53 AM · Restricted Project, Restricted Project
javedabsar closed D127072: [mlir][Inliner] Support recursion in Inliner.
Jun 30 2022, 10:53 AM · Restricted Project, Restricted Project
javedabsar added inline comments to D127072: [mlir][Inliner] Support recursion in Inliner.
Jun 30 2022, 7:19 AM · Restricted Project, Restricted Project
javedabsar updated the diff for D127072: [mlir][Inliner] Support recursion in Inliner.

fix

Jun 30 2022, 7:18 AM · Restricted Project, Restricted Project
javedabsar retitled D127072: [mlir][Inliner] Support recursion in Inliner from [mlir][Inliner] Bug-Fix #53492. Inliner goes into infinite loop to [mlir][Inliner] Support recursion in Inliner.
Jun 30 2022, 3:30 AM · Restricted Project, Restricted Project
javedabsar added inline comments to D127072: [mlir][Inliner] Support recursion in Inliner.
Jun 30 2022, 3:18 AM · Restricted Project, Restricted Project
javedabsar updated the diff for D127072: [mlir][Inliner] Support recursion in Inliner.

rename test

Jun 30 2022, 3:06 AM · Restricted Project, Restricted Project
javedabsar updated the diff for D127072: [mlir][Inliner] Support recursion in Inliner.

Fixes based on review comments.

Jun 30 2022, 3:04 AM · Restricted Project, Restricted Project

Jun 28 2022

javedabsar added a comment to D127072: [mlir][Inliner] Support recursion in Inliner.

Thanks for the review

Jun 28 2022, 10:49 AM · Restricted Project, Restricted Project
javedabsar abandoned D126545: [mlir][TableGen][NFC] Compact OpBase description.
Jun 28 2022, 10:24 AM · Restricted Project, Restricted Project
javedabsar updated the diff for D127072: [mlir][Inliner] Support recursion in Inliner.

Fix based on review feedback.

Jun 28 2022, 10:21 AM · Restricted Project, Restricted Project

Jun 22 2022

javedabsar added a comment to D127072: [mlir][Inliner] Support recursion in Inliner.
In D127072#3601560, @mehdi_amini wrote:

River is out this week, please ping again on Monday!

Jun 22 2022, 7:04 AM · Restricted Project, Restricted Project
javedabsar added a comment to D127072: [mlir][Inliner] Support recursion in Inliner.

gentle reminder

Jun 22 2022, 3:51 AM · Restricted Project, Restricted Project

Jun 21 2022

javedabsar updated the summary of D127072: [mlir][Inliner] Support recursion in Inliner.
Jun 21 2022, 6:39 AM · Restricted Project, Restricted Project

Jun 20 2022

javedabsar updated the diff for D127072: [mlir][Inliner] Support recursion in Inliner.

change based on review comments.
Use InlineHistory.

Jun 20 2022, 10:31 AM · Restricted Project, Restricted Project

Jun 6 2022

javedabsar added a comment to D127072: [mlir][Inliner] Support recursion in Inliner.
In D127072#3559111, @rriddle wrote:

Thanks for looking into this! Have you considered/looked into using the same approach as LLVM? i.e. keeping an inline history to track what's already been inlined?

Jun 6 2022, 3:55 AM · Restricted Project, Restricted Project
javedabsar added a comment to D126545: [mlir][TableGen][NFC] Compact OpBase description.

Is none of these changes desirable ? If so I will abandon this diff.

Jun 6 2022, 3:54 AM · Restricted Project, Restricted Project

Jun 5 2022

javedabsar added reviewers for D127072: [mlir][Inliner] Support recursion in Inliner: mehdi_amini, rriddle.
Jun 5 2022, 6:03 AM · Restricted Project, Restricted Project
javedabsar requested review of D127072: [mlir][Inliner] Support recursion in Inliner.
Jun 5 2022, 6:03 AM · Restricted Project, Restricted Project

May 29 2022

javedabsar committed rGc7283c263c0a: [mlir][NFC] Trivial : Fix typo (authored by javedabsar).
[mlir][NFC] Trivial : Fix typo
May 29 2022, 3:00 AM · Restricted Project, Restricted Project
javedabsar closed D126601: [mlir][NFC] Trivial : Fix typo.
May 29 2022, 3:00 AM · Restricted Project, Restricted Project

May 28 2022

javedabsar requested review of D126601: [mlir][NFC] Trivial : Fix typo.
May 28 2022, 12:52 PM · Restricted Project, Restricted Project
javedabsar added a comment to D126545: [mlir][TableGen][NFC] Compact OpBase description.

I have removed parts that reduced readibility. The ones left are like what would be common in llvm td files.
But if you reckon this doesnt help readability its ok i will abandon the diff.

May 28 2022, 5:19 AM · Restricted Project, Restricted Project
javedabsar updated the diff for D126545: [mlir][TableGen][NFC] Compact OpBase description.

Fix based on review comments

May 28 2022, 5:18 AM · Restricted Project, Restricted Project

May 27 2022

javedabsar requested review of D126545: [mlir][TableGen][NFC] Compact OpBase description.
May 27 2022, 7:55 AM · Restricted Project, Restricted Project

May 23 2022

javedabsar added reviewers for D126209: [mlir] Fix warning `missing base in copy ctor`: mehdi_amini, rriddle.
May 23 2022, 8:06 AM · Restricted Project, Restricted Project
javedabsar requested review of D126209: [mlir] Fix warning `missing base in copy ctor`.
May 23 2022, 8:05 AM · Restricted Project, Restricted Project

Mar 4 2019

javedabsar added a reviewer for D58895: [TableGen] Allow lists to be concatenated through '#': hfinkel.
Mar 4 2019, 2:50 AM · Restricted Project
javedabsar created D58895: [TableGen] Allow lists to be concatenated through '#'.
Mar 4 2019, 1:42 AM · Restricted Project