Page MenuHomePhabricator

javedabsar (Javed Absar)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2019, 1:28 AM (173 w, 1 d)

Recent Activity

Wed, Jun 22

javedabsar added a comment to D127072: [mlir][Inliner] Bug-Fix #53492. Inliner goes into infinite loop.

River is out this week, please ping again on Monday!

Wed, Jun 22, 7:04 AM · Restricted Project, Restricted Project
javedabsar added a comment to D127072: [mlir][Inliner] Bug-Fix #53492. Inliner goes into infinite loop.

gentle reminder

Wed, Jun 22, 3:51 AM · Restricted Project, Restricted Project

Tue, Jun 21

javedabsar updated the summary of D127072: [mlir][Inliner] Bug-Fix #53492. Inliner goes into infinite loop.
Tue, Jun 21, 6:39 AM · Restricted Project, Restricted Project

Mon, Jun 20

javedabsar updated the diff for D127072: [mlir][Inliner] Bug-Fix #53492. Inliner goes into infinite loop.

change based on review comments.
Use InlinHistory.

Mon, Jun 20, 10:31 AM · Restricted Project, Restricted Project

Mon, Jun 6

javedabsar added a comment to D127072: [mlir][Inliner] Bug-Fix #53492. Inliner goes into infinite loop.

Thanks for looking into this! Have you considered/looked into using the same approach as LLVM? i.e. keeping an inline history to track what's already been inlined?

Mon, Jun 6, 3:55 AM · Restricted Project, Restricted Project
javedabsar added a comment to D126545: [mlir][TableGen][NFC] Compact OpBase description.

Is none of these changes desirable ? If so I will abandon this diff.

Mon, Jun 6, 3:54 AM · Restricted Project, Restricted Project

Sun, Jun 5

javedabsar added reviewers for D127072: [mlir][Inliner] Bug-Fix #53492. Inliner goes into infinite loop: mehdi_amini, rriddle.
Sun, Jun 5, 6:03 AM · Restricted Project, Restricted Project
javedabsar requested review of D127072: [mlir][Inliner] Bug-Fix #53492. Inliner goes into infinite loop.
Sun, Jun 5, 6:03 AM · Restricted Project, Restricted Project

May 29 2022

javedabsar committed rGc7283c263c0a: [mlir][NFC] Trivial : Fix typo (authored by javedabsar).
[mlir][NFC] Trivial : Fix typo
May 29 2022, 3:00 AM · Restricted Project, Restricted Project
javedabsar closed D126601: [mlir][NFC] Trivial : Fix typo.
May 29 2022, 3:00 AM · Restricted Project, Restricted Project

May 28 2022

javedabsar requested review of D126601: [mlir][NFC] Trivial : Fix typo.
May 28 2022, 12:52 PM · Restricted Project, Restricted Project
javedabsar added a comment to D126545: [mlir][TableGen][NFC] Compact OpBase description.

I have removed parts that reduced readibility. The ones left are like what would be common in llvm td files.
But if you reckon this doesnt help readability its ok i will abandon the diff.

May 28 2022, 5:19 AM · Restricted Project, Restricted Project
javedabsar updated the diff for D126545: [mlir][TableGen][NFC] Compact OpBase description.

Fix based on review comments

May 28 2022, 5:18 AM · Restricted Project, Restricted Project

May 27 2022

javedabsar requested review of D126545: [mlir][TableGen][NFC] Compact OpBase description.
May 27 2022, 7:55 AM · Restricted Project, Restricted Project

May 23 2022

javedabsar added reviewers for D126209: [mlir] Fix warning `missing base in copy ctor`: mehdi_amini, rriddle.
May 23 2022, 8:06 AM · Restricted Project, Restricted Project
javedabsar requested review of D126209: [mlir] Fix warning `missing base in copy ctor`.
May 23 2022, 8:05 AM · Restricted Project, Restricted Project

Mar 4 2019

javedabsar added a reviewer for D58895: [TableGen] Allow lists to be concatenated through '#': hfinkel.
Mar 4 2019, 2:50 AM · Restricted Project
javedabsar created D58895: [TableGen] Allow lists to be concatenated through '#'.
Mar 4 2019, 1:42 AM · Restricted Project