PSTL should not provide those headers since they belong to the standard
library. Instead, we define a dummy standard library in the tests that
provides those headers.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
I'm not opposed to this change, but I wonder, should we then just remove the extra 'internal' directory, so that we get -
pstl/numeric_impl.h
?
Or should we move/rename the glue_Xxx files to pstl/ and keep everything else in pstl/internal ? Which is arguably now the library API after this change.
for libstdc++ I currently move 'internal' into 'pstl' so if do move/rename the glue files, I'd need to update my script (not an argument against doing this).
Comment Actions
Yes, doing something like that was the next step I was planning. As a different patch, though. Everything that's not part of the API of the library would stay in internal.