Page MenuHomePhabricator

[ASTImporter] Error handling fix in ImportDefinition_New.

Authored by balazske on Apr 9 2019, 7:57 AM.



ASTImporter::ImportDefinition_New contained a call to Import
that should be Import_New now. This is fixed now.

Diff Detail

Event Timeline

balazske created this revision.Apr 9 2019, 7:57 AM
Herald added a reviewer: shafik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
balazske updated this revision to Diff 194333.Apr 9 2019, 8:09 AM
  • Removed unneeded and wrong type cast.
balazske updated this revision to Diff 200901.May 23 2019, 2:33 AM

Rebase to current master.

balazske added a comment.EditedMay 23 2019, 2:39 AM

The error handling is already done in other way, but the current code does crash if called with non-DeclContext From argument. This may be possible from LLDB so it is better to have this change.

balazske abandoned this revision.Aug 22 2019, 1:40 AM

This change is obsolete in the current code. Casting related changes do not look important (and should be a new patch anyway).