Page MenuHomePhabricator

Dump the minimal version of cmake 3.5.0
AbandonedPublic

Authored by sylvestre.ledru on Apr 5 2019, 11:51 PM.

Details

Summary

This is done to mitigate a build issue with lldb specific to CMake 3.4.*

This won't be a major issue on old distro (Debian jessie or Ubuntu Trusty) as CMake 3.4 isn't available on these distros.

CMake Error at tools/lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt:12 (target_sources):
  Error evaluating generator expression:

    $<TARGET_OBJECTS:lldb-mi-utils>

  The evaluation of the TARGET_OBJECTS generator expression is only suitable
  for consumption by CMake.  It is not suitable for writing out elsewhere.

Version 3.5 has been released 2016-04-15
While 3.4: 2016-01-25

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2019, 11:51 PM
sylvestre.ledru edited the summary of this revision. (Show Details)Apr 6 2019, 12:12 AM
sylvestre.ledru added a reviewer: beanz.

Can you please explain in more detail how this is supposed to fix the issue?

We should certainly go to a newer CMake version soon, but I think it needs some more coordination (with other subprojects/LLVM) and it could be a bigger step forward once we do this.

I didn't look at the details. It was failing with 3.4, upgrading to 3.5 address the issue.

To me, this isn't a big deal as both 3.4 and 3.5 are old enough that modern distro have both of them (or none). See:

http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html

Ok, so far this appears to be a rare issue that we don't know much about. I think keeping LLVM and its subprojects in sync (which means CMake version 3.4.3) should be the prio for now.

sylvestre.ledru abandoned this revision.Apr 16 2019, 5:54 AM

As you wish.
People who might encounter the same issue will (hopefully) find this review

There is a workaround D63544 for fixing the issue in lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt without changing the minimum required cmake's version.