This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] Move the alias definition of unw_getcontext to within !defined(__USING_SJLJ_EXCEPTIONS__)
ClosedPublic

Authored by mstorsjo on Apr 3 2019, 11:13 PM.

Details

Summary

For builds with SJLJ, there is no __unw_getcontext symbol. On Windows, the weak alias macro also expands to a dllexport directive, which fails if the symbol doesn't exist.

Apparently I had forgotten to test actual builds with SJLJ, sorry for that omission.

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 3 2019, 11:13 PM
ldionne accepted this revision.Apr 4 2019, 8:09 AM
This revision is now accepted and ready to land.Apr 4 2019, 8:09 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2019, 10:48 AM