This is an archive of the discontinued LLVM Phabricator instance.

Differential D60251

[libunwind] Move the alias definition of unw_getcontext to within !defined(__USING_SJLJ_EXCEPTIONS__)
ClosedPublic

Authored by mstorsjo on Apr 3 2019, 11:13 PM.

Details

Reviewers
phosek
ldionne
mclow.lists
EricWF
Commits
rUNW357711: Move the alias definition of unw_getcontext to within !defined…
rG351ac8b1cc79: Move the alias definition of unw_getcontext to within !defined…
rL357711: Move the alias definition of unw_getcontext to within !defined…
Summary

For builds with SJLJ, there is no __unw_getcontext symbol. On Windows, the weak alias macro also expands to a dllexport directive, which fails if the symbol doesn't exist.

Apparently I had forgotten to test actual builds with SJLJ, sorry for that omission.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Apr 3 2019, 11:13 PM
Herald added a subscriber: dexonsmith. · View Herald TranscriptApr 3 2019, 11:13 PM
ldionne accepted this revision.Apr 4 2019, 8:09 AM
This revision is now accepted and ready to land.Apr 4 2019, 8:09 AM
Closed by commit rL357711: Move the alias definition of unw_getcontext to within !defined… (authored by mstorsjo). · Explain WhyApr 4 2019, 10:48 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2019, 10:48 AM
Herald added subscribers: llvm-commits, christof. · View Herald Transcript

Revision Contents

PathSize
libunwind/
trunk/
src/
3 lines

Diff 193749

libunwind/trunk/src/UnwindRegistersSave.S

Show First 20 Lines • Show All 966 Lines • ▼ Show 20 LinesDEFINE_LIBUNWIND_FUNCTION(__unw_getcontext)
std %l6, [%o0 + 88] std %l6, [%o0 + 88]
std %i0, [%o0 + 96] std %i0, [%o0 + 96]
std %i2, [%o0 + 104] std %i2, [%o0 + 104]
std %i4, [%o0 + 112] std %i4, [%o0 + 112]
std %i6, [%o0 + 120] std %i6, [%o0 + 120]
jmp %o7 jmp %o7
clr %o0 // return UNW_ESUCCESS clr %o0 // return UNW_ESUCCESS
#endif #endif
#endif /* !defined(__USING_SJLJ_EXCEPTIONS__) */
WEAK_ALIAS(__unw_getcontext, unw_getcontext) WEAK_ALIAS(__unw_getcontext, unw_getcontext)
#endif /* !defined(__USING_SJLJ_EXCEPTIONS__) */
NO_EXEC_STACK_DIRECTIVE NO_EXEC_STACK_DIRECTIVE