This is an archive of the discontinued LLVM Phabricator instance.

Differential D60238

Verify that Android targets generate DWARF 4 by default.
ClosedPublic

Authored by srhines on Apr 3 2019, 4:05 PM.

Details

Reviewers
aprantl
Commits
rG1ee8876d3d70: Verify that Android targets generate DWARF 4 by default.
rC357713: Verify that Android targets generate DWARF 4 by default.
rL357713: Verify that Android targets generate DWARF 4 by default.
Summary

In the future, Android releases will support DWARF 5, but we need to
ensure that older targets only have DWARF 4 generated for them. This
patch inserts that verification for all Android releases now. The patch
also fixes 2 minor mistakes (a mistakenly moved RUN line, and the
missing G_DWARF2 check label).

Diff Detail

Repository
rL LLVM

Event Timeline

srhines created this revision.Apr 3 2019, 4:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2019, 4:05 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
srhines added subscribers: pirama, chh.Apr 3 2019, 4:05 PM
Harbormaster completed remote builds in B30034: Diff 193621.Apr 3 2019, 4:06 PM
aprantl added inline comments.Apr 3 2019, 4:22 PM
clang/test/Driver/debug-options.c
280 ↗(On Diff #193621)

What's that for?

srhines marked an inline comment as done.Apr 3 2019, 4:52 PM
srhines added inline comments.
clang/test/Driver/debug-options.c
280 ↗(On Diff #193621)

Look at Line 30. You added references to it from a while ago, but it didn't exist.

aprantl accepted this revision.Apr 3 2019, 6:37 PM

Good catch!

This revision is now accepted and ready to land.Apr 3 2019, 6:37 PM
Closed by commit rL357713: Verify that Android targets generate DWARF 4 by default. (authored by srhines). · Explain WhyApr 4 2019, 11:16 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2019, 11:16 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
cfe/
trunk/
test/
Driver/
8 lines

Diff 193753

cfe/trunk/test/Driver/debug-options.c

Show All 11 Lines
// RUN: | FileCheck -check-prefix=G -check-prefix=G_GDB %s // RUN: | FileCheck -check-prefix=G -check-prefix=G_GDB %s
// RUN: %clang -### -c -ggdb1 %s -target x86_64-linux-gnu 2>&1 \ // RUN: %clang -### -c -ggdb1 %s -target x86_64-linux-gnu 2>&1 \
// RUN: | FileCheck -check-prefix=GLTO_ONLY -check-prefix=G_GDB %s // RUN: | FileCheck -check-prefix=GLTO_ONLY -check-prefix=G_GDB %s
// RUN: %clang -### -c -ggdb3 %s -target x86_64-linux-gnu 2>&1 \ // RUN: %clang -### -c -ggdb3 %s -target x86_64-linux-gnu 2>&1 \
// RUN: | FileCheck -check-prefix=G %s // RUN: | FileCheck -check-prefix=G %s
// RUN: %clang -### -c -glldb %s -target x86_64-linux-gnu 2>&1 \ // RUN: %clang -### -c -glldb %s -target x86_64-linux-gnu 2>&1 \
// RUN: | FileCheck -check-prefix=G -check-prefix=G_LLDB %s // RUN: | FileCheck -check-prefix=G -check-prefix=G_LLDB %s
// RUN: %clang -### -c -gsce %s -target x86_64-linux-gnu 2>&1 \ // RUN: %clang -### -c -gsce %s -target x86_64-linux-gnu 2>&1 \
// RUN: | FileCheck -check-prefix=G -check-prefix=G_SCE %s
// Android.
// Android should always generate DWARF4.
// RUN: %clang -### -c -g %s -target arm-linux-androideabi 2>&1 \
// RUN: | FileCheck -check-prefix=G -check-prefix=G_DWARF4 %s
// Darwin. // Darwin.
// RUN: | FileCheck -check-prefix=G -check-prefix=G_SCE %s
// RUN: %clang -### -c -g %s -target x86_64-apple-darwin 2>&1 \ // RUN: %clang -### -c -g %s -target x86_64-apple-darwin 2>&1 \
// RUN: | FileCheck -check-prefix=G_STANDALONE \ // RUN: | FileCheck -check-prefix=G_STANDALONE \
// RUN: -check-prefix=G_DWARF2 \ // RUN: -check-prefix=G_DWARF2 \
// RUN: -check-prefix=G_LLDB %s // RUN: -check-prefix=G_LLDB %s
// RUN: %clang -### -c -g %s -target x86_64-apple-darwin16 2>&1 \ // RUN: %clang -### -c -g %s -target x86_64-apple-darwin16 2>&1 \
// RUN: | FileCheck -check-prefix=G_STANDALONE \ // RUN: | FileCheck -check-prefix=G_STANDALONE \
// RUN: -check-prefix=G_DWARF4 \ // RUN: -check-prefix=G_DWARF4 \
// RUN: -check-prefix=G_LLDB %s // RUN: -check-prefix=G_LLDB %s
▲ Show 20 Lines • Show All 236 Lines • ▼ Show 20 Lines
// These tests assert that "-gline-tables-only" "-g" uses the latter, // These tests assert that "-gline-tables-only" "-g" uses the latter,
// but otherwise not caring about the DebugInfoKind. // but otherwise not caring about the DebugInfoKind.
// G_ONLY_DWARF2: "-cc1" // G_ONLY_DWARF2: "-cc1"
// G_ONLY_DWARF2: "-debug-info-kind={{standalone|limited}}" // G_ONLY_DWARF2: "-debug-info-kind={{standalone|limited}}"
// G_ONLY_DWARF2: "-dwarf-version=2" // G_ONLY_DWARF2: "-dwarf-version=2"
// //
// G_STANDALONE: "-cc1" // G_STANDALONE: "-cc1"
// G_STANDALONE: "-debug-info-kind=standalone" // G_STANDALONE: "-debug-info-kind=standalone"
// G_DWARF2: "-dwarf-version=2"
// G_DWARF4: "-dwarf-version=4" // G_DWARF4: "-dwarf-version=4"
// //
// G_GDB: "-debugger-tuning=gdb" // G_GDB: "-debugger-tuning=gdb"
// G_LLDB: "-debugger-tuning=lldb" // G_LLDB: "-debugger-tuning=lldb"
// G_SCE: "-debugger-tuning=sce" // G_SCE: "-debugger-tuning=sce"
// //
// G_NOTUNING: "-cc1" // G_NOTUNING: "-cc1"
// G_NOTUNING-NOT: "-debugger-tuning=" // G_NOTUNING-NOT: "-debugger-tuning="
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines