Page MenuHomePhabricator

Verify that Android targets generate DWARF 4 by default.
ClosedPublic

Authored by srhines on Apr 3 2019, 4:05 PM.

Details

Summary

In the future, Android releases will support DWARF 5, but we need to
ensure that older targets only have DWARF 4 generated for them. This
patch inserts that verification for all Android releases now. The patch
also fixes 2 minor mistakes (a mistakenly moved RUN line, and the
missing G_DWARF2 check label).

Diff Detail

Repository
rL LLVM

Event Timeline

srhines created this revision.Apr 3 2019, 4:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2019, 4:05 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aprantl added inline comments.Apr 3 2019, 4:22 PM
clang/test/Driver/debug-options.c
280 ↗(On Diff #193621)

What's that for?

srhines marked an inline comment as done.Apr 3 2019, 4:52 PM
srhines added inline comments.
clang/test/Driver/debug-options.c
280 ↗(On Diff #193621)

Look at Line 30. You added references to it from a while ago, but it didn't exist.

aprantl accepted this revision.Apr 3 2019, 6:37 PM

Good catch!

This revision is now accepted and ready to land.Apr 3 2019, 6:37 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2019, 11:16 AM