This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy] Make section rename/set flags case-insensitive
ClosedPublic

Authored by jhenderson on Apr 3 2019, 7:12 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

jhenderson created this revision.Apr 3 2019, 7:12 AM
grimar accepted this revision.Apr 3 2019, 7:22 AM

LGTM with a nit.

test/tools/llvm-objcopy/ELF/set-section-flags.test
69 ↗(On Diff #193487)

Perhaps separating into two independent blocks would be a bit more readable?

# Upper case flags:
# RUN: ...
...

# Mixed-case flags:
# RUN: ...
...
This revision is now accepted and ready to land.Apr 3 2019, 7:22 AM
This revision was automatically updated to reflect the committed changes.

LGTM with a nit.

Oops, forgot to do that. I'll fix that in an NFC.