Page MenuHomePhabricator

[mips] MIPS BEQZL and BNEZL instructions
AbandonedPublic

Authored by atanasyan on Oct 28 2014, 9:16 AM.

Details

Summary

This patch adds support for the BEQZL and BNEZL MIPS instruction aliases. Besides the support, corresponding assembler and dissasembler tests are also added.

Diff Detail

Event Timeline

ipetkovic updated this revision to Diff 15526.Oct 28 2014, 9:16 AM
ipetkovic retitled this revision from to [mips] MIPS BEQZL and BNEZL instructions.
ipetkovic updated this object.
ipetkovic edited the test plan for this revision. (Show Details)
ipetkovic added a subscriber: petarj.
dsanders resigned from this revision.Jul 12 2019, 4:09 PM
atanasyan commandeered this revision.Jul 12 2019, 10:43 PM
atanasyan abandoned this revision.
atanasyan added a reviewer: ipetkovic.

Implemented at the rL234401.

Maybe we should add the tests that this patch had since they were not added in rL234401.
rL234401 also disabled printing of the alias instruction while it's enabled in here. Not sure which one is preferable.

Maybe we should add the tests that this patch had since they were not added in rL234401.
rL234401 also disabled printing of the alias instruction while it's enabled in here. Not sure which one is preferable.

Good point. Fixed at rL366133.

Should we also add the (dis)assembler tests or are these case covered in other tests?

Should we also add the (dis)assembler tests or are these case covered in other tests?

Thanks. Fixed at rL367168.