This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Rename span's as_writeable_bytes to as_writable_bytes
ClosedPublic

Authored by ldionne on Mar 27 2019, 8:09 AM.

Event Timeline

ldionne created this revision.Mar 27 2019, 8:09 AM

This is NOT an ABI break because the methods involved have INLINE_VISIBILITY.

This IS an API break because we're renaming a function. However, I suspect that function isn't used all that often, and for those users that will be broken, the fix is trivial (just rename the function). I also know that we haven't been shipping this for a long time, so there isn't like years of code written on top of this bug. This is why I suggest we don't try to retain the old name.

mclow.lists accepted this revision.Mar 27 2019, 5:17 PM

And it is part of C++20, so it's not final anyway.

This revision is now accepted and ready to land.Mar 27 2019, 5:17 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2019, 6:29 PM
libcxx/test/std/containers/views/span.objectrep/as_writable_bytes.pass.cpp