It's handling isses as described here:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89832
Patch by Martin Liška.
Paths
| Differential D59876
Improve error message when '=' is missing in {ASAN,...}_OPTIONS. ClosedPublic Authored by marxin on Mar 27 2019, 6:16 AM.
Details Summary It's handling isses as described here: Patch by Martin Liška.
Diff Detail Event Timeline
marxin marked 3 inline comments as done. marxin added inline comments.
This revision is now accepted and ready to land.Jun 12 2019, 1:56 PM Comment Actions
http://lab.llvm.org:8011 is down Closed by commit rL363480: Improve error message when '=' is missing in {ASAN,...}_OPTIONS. (authored by vitalybuka). · Explain WhyJun 14 2019, 6:34 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 204226 lib/asan/asan_flags.cc
lib/cfi/cfi.cpp
lib/dfsan/dfsan.cc
lib/hwasan/hwasan.cpp
lib/lsan/lsan.cc
lib/msan/msan.cc
lib/sanitizer_common/sancov_flags.cc
lib/sanitizer_common/sanitizer_flag_parser.h
lib/sanitizer_common/sanitizer_flag_parser.cc
lib/scudo/scudo_flags.cpp
lib/tsan/dd/dd_rtl.cc
lib/tsan/rtl/tsan_flags.h
lib/tsan/rtl/tsan_flags.cc
lib/tsan/rtl/tsan_rtl.cc
lib/ubsan/ubsan_flags.cc
lib/xray/xray_flags.cc
test/sanitizer_common/TestCases/options-error-message.cc
|
If we are making ParseString to know that this is an env option we should just add
asan_parser.ParseStringFromEnv("ASAN_OPTIONS");
and call GetEnv in implementation
Is anything blocks us from that?