Regression test to ensure that we handling importing of std::vector of enums correctly

[shafik]

Summary

https://reviews.llvm.org/D59845 added a fix for the IsStructuralMatch(...) specialization for EnumDecl this test should pass once this fix is committed.

[friss]

As we're just adding test coverage, could we add a little more?

• Anonymous enum
• Enum through a typedef
• class enum
• enum declared inside of the function rather than at the top-level
• nested enum in a record type
• enum nested in a templated class
• anything else I haven't thought about...

[shafik]

In D59847#1443905, @friss wrote:

As we're just adding test coverage, could we add a little more?

• Anonymous enum
• Enum through a typedef
• class enum
• enum declared inside of the function rather than at the top-level
• nested enum in a record type
• enum nested in a templated class
• anything else I haven't thought about...

Sure that makes sense.

[shafik]

@friss so far I have not found any other scenarios that relate specifically to this test outside of the one I already have here https://reviews.llvm.org/D59667

I did find some other bugs though. I will do some more tests as a separate PR unless I can find one directly related.

[stella.stamenova]

This is causing failures on the windows bot. Please fix it or revert it.

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/3066

[shafik]

In D59847#1446571, @stella.stamenova wrote:

This is causing failures on the windows bot. Please fix it or revert it.

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/3066

I think I know why this is breaking, it relies on the formatter for std::vector I believe add the "libc++" test category should fix this, let me work on getting that fix in.

[shafik]

@stella.stamenova I committed a fix, please let me know if this does not address the regression:

http://llvm.org/viewvc/llvm-project?view=revision&revision=357210

[stella.stamenova]

In D59847#1446671, @shafik wrote:

@stella.stamenova I committed a fix, please let me know if this does not address the regression:

http://llvm.org/viewvc/llvm-project?view=revision&revision=357210

@shafik Thanks! You can keep an eye to make sure the buildbot returns to green here: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot, but I will as well.

lldb/trunk/packages/Python/lldbsuite/test/expression_command/vector_of_enums/Makefile

+LEVEL = ../../make
+
+CXX_SOURCES := main.cpp
+
+include $(LEVEL)/Makefile.rules

lldb/trunk/packages/Python/lldbsuite/test/expression_command/vector_of_enums/TestVectorOfEnums.py

+"""
+Test Expression Parser regression test to ensure that we handle enums
+correctly, in this case specifically std::vector of enums.
+"""
+
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+class TestVectorOfEnums(TestBase):
+
+  mydir = TestBase.compute_mydir(__file__)
+
+  def test_vector_of_enums(self):
+    self.build()
+
+    lldbutil.run_to_source_breakpoint(self, '// break here',
+            lldb.SBFileSpec("main.cpp", False))
+
+    self.expect("expr v", substrs=[
+         'size=3',
+         '[0] = a',
+         '[1] = b',
+         '[2] = c',
+         '}'
+        ])

lldb/trunk/packages/Python/lldbsuite/test/expression_command/vector_of_enums/main.cpp

+#include <vector>
+
+enum E {
+a,
+b,
+c,
+d
+} ;
+
+int main() {
+  std::vector<E> v = {E::a, E::b, E::c};
+
+  return v.size(); // break here
+}