Page MenuHomePhabricator

Regression test to ensure that we handling importing of std::vector of enums correctly
ClosedPublic

Authored by shafik on Mar 26 2019, 2:28 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

shafik created this revision.Mar 26 2019, 2:28 PM
aprantl accepted this revision.Mar 26 2019, 2:37 PM
This revision is now accepted and ready to land.Mar 26 2019, 2:37 PM
friss added a comment.Mar 26 2019, 5:19 PM

As we're just adding test coverage, could we add a little more?

  • Anonymous enum
  • Enum through a typedef
  • class enum
  • enum declared inside of the function rather than at the top-level
  • nested enum in a record type
  • enum nested in a templated class
  • anything else I haven't thought about...

As we're just adding test coverage, could we add a little more?

  • Anonymous enum
  • Enum through a typedef
  • class enum
  • enum declared inside of the function rather than at the top-level
  • nested enum in a record type
  • enum nested in a templated class
  • anything else I haven't thought about...

Sure that makes sense.

@friss so far I have not found any other scenarios that relate specifically to this test outside of the one I already have here https://reviews.llvm.org/D59667

I did find some other bugs though. I will do some more tests as a separate PR unless I can find one directly related.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2019, 10:20 AM

This is causing failures on the windows bot. Please fix it or revert it.

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/3066

This is causing failures on the windows bot. Please fix it or revert it.

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/3066

I think I know why this is breaking, it relies on the formatter for std::vector I believe add the "libc++" test category should fix this, let me work on getting that fix in.

@stella.stamenova I committed a fix, please let me know if this does not address the regression:

http://llvm.org/viewvc/llvm-project?view=revision&revision=357210

@stella.stamenova I committed a fix, please let me know if this does not address the regression:

http://llvm.org/viewvc/llvm-project?view=revision&revision=357210

@shafik Thanks! You can keep an eye to make sure the buildbot returns to green here: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot, but I will as well.