Page MenuHomePhabricator

[LLD] Restore tests that use "-" as output
ClosedPublic

Authored by andrewng on Mar 26 2019, 9:20 AM.

Details

Summary

No longer require workarounds for output to "-" (stdout) for
Windows. These workarounds were just hiding the actual problem which is
fixed by patch D59663. This needs to land after D59663.

Diff Detail

Repository
rL LLVM

Event Timeline

andrewng created this revision.Mar 26 2019, 9:20 AM
ruiu accepted this revision.Mar 26 2019, 9:33 AM

LGTM

This revision is now accepted and ready to land.Mar 26 2019, 9:33 AM

I think there are more tests that should use -o - in wasm/target-feature-none.yaml, but otherwise the wasm changes lgtm.

I think there are more tests that should use -o - in wasm/target-feature-none.yaml, but otherwise the wasm changes lgtm.

Thanks for pointing that out. I'll update that test too (assuming the dependent patch lands OK).

Closed by commit rL357072: [LLD] Restore tests that use "-" as output (authored by anng, committed by ). · Explain WhyMar 27 2019, 8:29 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2019, 8:29 AM