Page MenuHomePhabricator

[llvm-dlltool] Set a proper machine type for weak symbol object files
ClosedPublic

Authored by mstorsjo on Mar 23 2019, 1:44 PM.

Details

Summary

This makes GNU binutils not reject the libraries outright.

GNU ld handles weak externals slightly differently though, so it can't use them for aliases in import libraries, but this makes GNU ld able to use the rest of the import libraries.

LLD hasn't had issues with the bogus machine field though.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Mar 23 2019, 1:44 PM
ruiu accepted this revision.Mar 25 2019, 12:46 PM

LGTM

This revision is now accepted and ready to land.Mar 25 2019, 12:46 PM
This revision was automatically updated to reflect the committed changes.

@tstellard - This would be nice to have in 8.0.1 as well.

(Sorry for the double post due to a typo) @tstellar - This would be nice to have in 8.0.1 as well.