This is an archive of the discontinued LLVM Phabricator instance.

Differential D59736

Fix interoperability test compilation on FreeBSD
ClosedPublic

Authored by dim on Mar 23 2019, 7:43 AM.

Details

Reviewers
emaste
jlpeyton
krytarowski
mgorny
protze.joachim
Commits
rGa70da7f29f9d: Fix interoperability test compilation on FreeBSD
rL356936: Fix interoperability test compilation on FreeBSD
rOMP356936: Fix interoperability test compilation on FreeBSD
Summary

While building the 8.0 releases on FreeBSD, I encountered the following
error in the regression tests, where ompt/misc/interoperability.cpp
failed to compile, with:

projects/openmp/runtime/test/ompt/misc/interoperability.cpp:7:10: fatal error: 'alloca.h' file not found
#include <alloca.h>
         ^~~~~~~~~~

Like on NetBSD, alloca(3) is defined in <stdlib.h> instead.

Diff Detail

Repository
rOMP OpenMP

Event Timeline

dim created this revision.Mar 23 2019, 7:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2019, 7:43 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
Harbormaster completed remote builds in B29533: Diff 191996.Mar 23 2019, 7:44 AM
dim mentioned this in D59451: Fix gettid warnings and one test on FreeBSD.Mar 23 2019, 7:45 AM
jlpeyton accepted this revision.Mar 25 2019, 10:31 AM

LGTM

This revision is now accepted and ready to land.Mar 25 2019, 10:31 AM
Closed by commit rOMP356936: Fix interoperability test compilation on FreeBSD (authored by dim). · Explain WhyMar 25 2019, 11:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
runtime/
test/
ompt/
misc/
2 lines

Diff 192170

runtime/test/ompt/misc/interoperability.cpp

// RUN: %libomp-cxx-compile-and-run | %sort-threads | FileCheck %s // RUN: %libomp-cxx-compile-and-run | %sort-threads | FileCheck %s
// REQUIRES: ompt // REQUIRES: ompt
#include <iostream> #include <iostream>
#include <thread> #include <thread>
#if !defined(__NetBSD__) #if !defined(__FreeBSD__) && !defined(__NetBSD__)
#include <alloca.h> #include <alloca.h>
#else #else
#include <cstdlib> #include <cstdlib>
#endif #endif
#include "callback.h" #include "callback.h"
#include "omp.h" #include "omp.h"
▲ Show 20 Lines • Show All 105 Lines • Show Last 20 Lines