Page MenuHomePhabricator

AMDGPU: Ignore SRAM ECC feature when inlining
AbandonedPublic

Authored by kzhuravl on Mar 22 2019, 2:08 PM.

Details

Diff Detail

Event Timeline

kzhuravl created this revision.Mar 22 2019, 2:08 PM
This revision is now accepted and ready to land.Mar 22 2019, 2:15 PM
arsenm requested changes to this revision.Mar 22 2019, 2:16 PM

This isn't correct, this does impact codegen. This changes whether d16 instruction can be used

This revision now requires changes to proceed.Mar 22 2019, 2:16 PM

Non ECC functions can safely call ECC functions, but not the other way around. Can you add tests for both directions?

This isn't correct, this does impact codegen. This changes whether d16 instruction can be used

But these instructions created after any inlining.

This isn't correct, this does impact codegen. This changes whether d16 instruction can be used

But these instructions created after any inlining.

The features should be consistent with no knowledge of the function body. An ecc function calling a non-ecc function is potentially broken, so it shouldn’t be inlined

kzhuravl abandoned this revision.Apr 2 2019, 12:42 PM