Python 2/3 compat: urllib

[labath]

Someone from the LLD(not B) project should review this.

[serge-sans-paille]

@michaelplatings up!

[peter.smith]

I think that this change has already been committed as r356538 with an almost identical diff (only difference is the path to benchmark.py including trunk) at D59538 which is already approved. Were you intending this review to be for some other change such as LLDB? FWIW I've no objections to the changes.

[serge-sans-paille]

Yep, that's clearly a duplicate that was hanging around in my patch list, sorry for the noise.

lld/utils/benchmark.py

 import json
 import datetime
 import argparse
-import urllib
-import urllib2
+try:
+    from urllib.parse import urlencode
+    from urllib.request import urlopen, Request
+except ImportError:
+    from urllib import urlencode
+    from urllib2 import urlopen, Request
+
 
 parser = argparse.ArgumentParser()
 parser.add_argument('benchmark_directory')

     return json.dumps(ret, sort_keys=True, indent=4)
 
 def submitToServer(data):
-    data2 = urllib.urlencode({ 'input_data' : data }).encode('ascii')
-    urllib2.urlopen(urllib2.Request(args.url, data2))
+    data2 = urlencode({ 'input_data' : data }).encode('ascii')
+    urlopen(Request(args.url, data2))
 
 os.chdir(args.benchmark_directory)
 data = buildLntJson(getBenchmarks())