Page MenuHomePhabricator

Make __cpu_model a hidden symbol, to match libgcc.
ClosedPublic

Authored by saugustine on Mar 19 2019, 2:05 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

saugustine created this revision.Mar 19 2019, 2:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2019, 2:05 PM
kongyi added a subscriber: kongyi.
kongyi added inline comments.
compiler-rt/lib/builtins/cpu_model.c
606 ↗(On Diff #191392)

Please also mark __cpu_features2 as hidden.

hhb added a subscriber: hhb.Mar 19 2019, 5:43 PM
hhb added inline comments.
compiler-rt/lib/builtins/cpu_model.c
615 ↗(On Diff #191392)

And __cpu_indicator_init just in case. It is already used as hidden symbol in __builtin_cpu_init codegen.

  • Also hide __cpu_inicator_init for similar reasons.
saugustine marked 2 inline comments as done.

Make cpu_model a hidden symbol, to match libgcc.
Also
cpu_features2 and __cpu_indicator_init.

Thanks. I've hidden a couple more symbols Please take another look.

This revision is now accepted and ready to land.Mar 20 2019, 10:22 AM
This revision was automatically updated to reflect the committed changes.