Page MenuHomePhabricator

AMDGPU: Add support for cross address space synchronization scopes
ClosedPublic

Authored by kzhuravl on Mar 18 2019, 3:37 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

kzhuravl created this revision.Mar 18 2019, 3:37 PM

This still requires some more tests to be added (which I am working on), and docs updated. I just wanted to get this out here for some early code reviews and testing on hw.

arsenm added inline comments.Mar 18 2019, 3:41 PM
lib/Target/AMDGPU/AMDGPUMachineModuleInfo.h
72 ↗(On Diff #191194)

Should expand name, "As" is not clear

94 ↗(On Diff #191194)

Ditto for the rest

kzhuravl updated this revision to Diff 191384.Mar 19 2019, 1:33 PM
kzhuravl marked 2 inline comments as done.

Added docs and tests. Addressed review feedback.

This revision is now accepted and ready to land.Mar 19 2019, 1:40 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2019, 1:49 PM