This is an archive of the discontinued LLVM Phabricator instance.

[X86] Remove the _alt forms of (V)CMP instructions. Use a combination of custom printing and custom parsing to achieve the same result and more
ClosedPublic

Authored by craig.topper on Mar 17 2019, 1:17 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

craig.topper created this revision.Mar 17 2019, 1:17 AM
craig.topper marked an inline comment as done.Mar 17 2019, 1:22 AM
craig.topper added inline comments.
lib/Target/X86/Disassembler/X86Disassembler.cpp
472 ↗(On Diff #191009)

I should note this list was very incomplete. If any of the masked forms were disassembled with an out of range immediate, an assertion would be thrown. Same for broadcast verisons with and without masking

RKSimon added inline comments.Mar 17 2019, 11:58 AM
lib/Target/X86/AsmParser/X86AsmParser.cpp
2327 ↗(On Diff #191009)

Is this just a microoptimizion? It all looks a little messy

2391 ↗(On Diff #191009)

Again - why not just use endswith()?

Switch back to using endswith

Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2019, 2:35 PM
Herald added a subscriber: kristina. · View Herald Transcript
RKSimon accepted this revision.Mar 18 2019, 2:16 AM

LGTM

This revision is now accepted and ready to land.Mar 18 2019, 2:16 AM
This revision was automatically updated to reflect the committed changes.