Page MenuHomePhabricator

[WebAssembly] Change wasm.throw's first argument to an immediate
ClosedPublic

Authored by aheejin on Mar 16 2019, 12:47 AM.

Diff Detail

Repository
rC Clang

Event Timeline

aheejin created this revision.Mar 16 2019, 12:47 AM
aheejin retitled this revision from [WebAssembly] Change wasm.throw intrinsic's first argument to immediate to [WebAssembly] Change wasm.throw's first argument to an immediate.Mar 16 2019, 12:47 AM
dschuff accepted this revision.Mar 18 2019, 12:54 PM

LGTM; I wonder if it makes sense to have predefined macro for the C++ tag (or perhaps just a regular macro for use in libcxxabi?)

This revision is now accepted and ready to land.Mar 18 2019, 12:54 PM

Shouldn't the definition in BuiltinsWebAssembly.def be updated to include an 'I' in the type string so that this will be properly diagnosed in the frontend?

LGTM; I wonder if it makes sense to have predefined macro for the C++ tag (or perhaps just a regular macro for use in libcxxabi?)

The only place the throw builtin will be used in within __cxa_throw function in libcxxabi, so I guess some regular macro in libcxxabi would be fine.

aheejin updated this revision to Diff 191240.Mar 18 2019, 9:52 PM
  • Add I to wasm.throw builtin's tag argument

Shouldn't the definition in BuiltinsWebAssembly.def be updated to include an 'I' in the type string so that this will be properly diagnosed in the frontend?

Done. Thank you for checking!

aheejin edited the summary of this revision. (Show Details)Mar 18 2019, 9:54 PM
aheejin added a reviewer: craig.topper.
This revision was automatically updated to reflect the committed changes.