This is an archive of the discontinued LLVM Phabricator instance.

Differential D59404

[ELF] Add a test for large .bss.rel.ro
ClosedPublic

Authored by MaskRay on Mar 14 2019, 7:37 PM.

Details

Reviewers
ruiu
pcc
• espindola
Commits
rG639058d7c947: [ELF] Add a test for large .bss.rel.ro
rLLD356230: [ELF] Add a test for large .bss.rel.ro
rL356230: [ELF] Add a test for large .bss.rel.ro

Diff Detail

Event Timeline

MaskRay created this revision.Mar 14 2019, 7:37 PM
Herald added a reviewer: • espindola. · View Herald TranscriptMar 14 2019, 7:37 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, arichardson, emaste. · View Herald Transcript
Harbormaster completed remote builds in B29195: Diff 190773.Mar 14 2019, 7:37 PM
pcc added inline comments.Mar 14 2019, 8:09 PM
test/ELF/relro-bss.s
9

I'd test the program headers explicitly here, so that you can be sure that all of the fields are correct.

MaskRay updated this revision to Diff 190776.Mar 14 2019, 8:25 PM

Add check lines for segment layout

MaskRay marked an inline comment as done.Mar 14 2019, 8:25 PM
Harbormaster completed remote builds in B29196: Diff 190776.Mar 14 2019, 8:26 PM
pcc accepted this revision.Mar 14 2019, 8:27 PM

LGTM

This revision is now accepted and ready to land.Mar 14 2019, 8:27 PM
MaskRay updated this revision to Diff 190777.Mar 14 2019, 8:29 PM

Add a comment

Harbormaster completed remote builds in B29197: Diff 190777.Mar 14 2019, 8:29 PM
MaskRay updated this revision to Diff 190778.Mar 14 2019, 8:33 PM

Adjust comment

Harbormaster completed remote builds in B29198: Diff 190778.Mar 14 2019, 8:33 PM
Closed by commit rL356230: [ELF] Add a test for large .bss.rel.ro (authored by MaskRay). · Explain WhyMar 14 2019, 8:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
ELF/
44 lines

Diff 190777

test/ELF/relro-bss.s

  • This file was added.
# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
# RUN: ld.lld %t.o -o %t
# RUN: llvm-readelf -l %t | FileCheck --check-prefix=SEG %s
# RUN: llvm-readelf -S %t | FileCheck %s
# We have 2 RW PT_LOAD segments. p_offset p_paddr p_filesz of the first should
# match PT_GNU_RELRO. Since we have .bss.rel.ro (nobits), p_filesz < p_memsz.
pccUnsubmitted
Done
ReplyInline Actions

I'd test the program headers explicitly here, so that you can be sure that all of the fields are correct.

pcc: I'd test the program headers explicitly here, so that you can be sure that all of the fields…
# Type Offset VirtAddr PhysAddr FileSiz MemSiz Flg Align
# SEG: LOAD 0x001000 0x0000000000201000 0x0000000000201000 0x000001 0x000001 R E 0x1000
# SEG-NEXT: LOAD 0x002000 0x0000000000202000 0x0000000000202000 0x000001 0x002001 RW 0x1000
# SEG-NEXT: LOAD 0x003000 0x0000000000205000 0x0000000000205000 0x000001 0x000002 RW 0x1000
# SEG-NEXT: GNU_RELRO 0x002000 0x0000000000202000 0x0000000000202000 0x000001 0x003000 R 0x1
# SEG-NEXT: GNU_STACK 0x000000 0x0000000000000000 0x0000000000000000 0x000000 0x000000 RW 0x0
# SEG: .text
# SEG-NEXT: .data.rel.ro .bss.rel.ro
# SEG-NEXT: .data .bss
# Because .bss.rel.ro is nobits, .data is placed in the next page
# (sh_offset = alignTo(0x2001, 4096) = 0x3000).
# [Nr] Name Type Address Off Size
# CHECK: .data.rel.ro PROGBITS 0000000000202000 002000 000001
# CHECK-NEXT: .bss.rel.ro NOBITS 0000000000202001 002001 002000
# CHECK-NEXT: .data PROGBITS 0000000000205000 003000 000001
# CHECK-NEXT: .bss NOBITS 0000000000205001 003001 000001
.globl _start
_start:
ret
.section .data.rel.ro, "aw"
.space 1
.section .bss.rel.ro, "aw", @nobits
.space 8192
.section .data, "aw"
.space 1
.section .bss, "aw"
.space 1