Page MenuHomePhabricator

[ELF] Add a test for large .bss.rel.ro
ClosedPublic

Authored by MaskRay on Mar 14 2019, 7:37 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Mar 14 2019, 7:37 PM
pcc added inline comments.Mar 14 2019, 8:09 PM
test/ELF/relro-bss.s
8 ↗(On Diff #190773)

I'd test the program headers explicitly here, so that you can be sure that all of the fields are correct.

MaskRay updated this revision to Diff 190776.Mar 14 2019, 8:25 PM

Add check lines for segment layout

MaskRay marked an inline comment as done.Mar 14 2019, 8:25 PM
pcc accepted this revision.Mar 14 2019, 8:27 PM

LGTM

This revision is now accepted and ready to land.Mar 14 2019, 8:27 PM
MaskRay updated this revision to Diff 190777.Mar 14 2019, 8:29 PM

Add a comment

MaskRay updated this revision to Diff 190778.Mar 14 2019, 8:33 PM

Adjust comment

This revision was automatically updated to reflect the committed changes.